From: Tejas Vipin <tejasvipin76@gmail.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
Laurent.pinchart@ideasonboard.com, patrik.r.jakobsson@gmail.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
airlied@gmail.com, daniel@ffwll.ch
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/gma500: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi
Date: Thu, 12 Sep 2024 19:59:42 +0530 [thread overview]
Message-ID: <4c053d01-2f67-47c3-9f08-e20e8e6ef1dd@gmail.com> (raw)
In-Reply-To: <b0f77fcc-5d84-4727-9a17-9d1f1e2c5b76@suse.de>
On 9/12/24 12:49 PM, Thomas Zimmermann wrote:
> Hi
>
> Am 11.09.24 um 20:06 schrieb Tejas Vipin:
>> Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi since
>> monitor HDMI information is available after EDID is parsed. Additionally
>> rewrite the code the code to have fewer indentation levels.
>
> The problem is that the entire logic is outdated. The content of cdv_hdmi_detect() should go into cdv_hdmi_get_modes(), the detect_ctx callback should be set to drm_connector_helper_detect_from_ddc() and cdv_hdmi_detect() should be deleted. The result is that ->detect_ctx will detect the presence of a display and ->get_modes will update EDID and other properties.
>
> Do you have a device for testing such a change?
>
> Best regards
> Thomas
I do not have a device to test this. Reading the rest of the series and
given my circumstances, I do not think I will be continuing with this
patch.
--
Tejas Vipin
next prev parent reply other threads:[~2024-09-12 14:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 18:06 Tejas Vipin
2024-09-12 7:19 ` Thomas Zimmermann
2024-09-12 8:48 ` Jani Nikula
2024-09-12 8:56 ` Jani Nikula
2024-09-12 9:26 ` Thomas Zimmermann
2024-09-12 9:38 ` Jani Nikula
2024-09-12 10:45 ` Thomas Zimmermann
2024-09-12 11:25 ` Jani Nikula
2024-09-12 13:10 ` Thomas Zimmermann
2024-09-12 13:25 ` Jani Nikula
2024-09-12 9:18 ` Thomas Zimmermann
2024-09-12 9:30 ` Jani Nikula
2024-09-12 11:08 ` Thomas Zimmermann
2024-09-12 13:30 ` Ville Syrjälä
2024-09-12 14:29 ` Tejas Vipin [this message]
2024-09-23 9:36 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c053d01-2f67-47c3-9f08-e20e8e6ef1dd@gmail.com \
--to=tejasvipin76@gmail.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=patrik.r.jakobsson@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®