From: David Lechner <dlechner@baylibre.com>
To: marius.cristea@microchip.com, jic23@kernel.org,
nuno.sa@analog.com, andy@kernel.org
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
broonie@kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] iio: adc: add support for PAC194X
Date: Sat, 16 May 2026 11:40:16 -0500 [thread overview]
Message-ID: <4c1b2887-1e95-4723-b42e-329ef5b1ee90@baylibre.com> (raw)
In-Reply-To: <20260515092946.10791-3-marius.cristea@microchip.com>
On 5/15/26 4:29 AM, marius.cristea@microchip.com wrote:
> From: Marius Cristea <marius.cristea@microchip.com>
>
> This is the iio driver for Microchip PAC194X and PAC195X series of
> Power Monitors with Accumulator. The PAC194X family supports 9V
> Full-Scale Range and the PAC195X supports 32V Full-Scale Range.
>
> There are two versions of the PAC194X/5X: the PAC194X/5X-1 devices
> are for high-side current sensing and the PAC194X/5X-2 devices are
> for low-side current sensing or floating VBUS applications. The
> PAC194X/5X-1 is named shortly PAC194X/5X.
>
> Signed-off-by: Marius Cristea <marius.cristea@microchip.com>
> ---
> MAINTAINERS | 1 +
> drivers/iio/adc/Kconfig | 12 +
> drivers/iio/adc/Makefile | 1 +
> drivers/iio/adc/pac1944.c | 2172 +++++++++++++++++++++++++++++++++++++
> 4 files changed, 2186 insertions(+)
> create mode 100644 drivers/iio/adc/
Can we please split this up into multiple patches by feature added?
We are already drowning in reviews here in the IIO subsystem. It takes
many times longer to review things that are not split up into bite-sized
pieces (aim for 500 lines in a patch).
next prev parent reply other threads:[~2026-05-16 16:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 9:29 [PATCH v4 0/2] add support for Microchip PAC194X Power Monitor marius.cristea
2026-05-15 9:29 ` [PATCH v4 1/2] dt-bindings: iio: adc: add support for PAC1944 marius.cristea
2026-05-15 17:29 ` Conor Dooley
2026-05-15 9:29 ` [PATCH v4 2/2] iio: adc: add support for PAC194X marius.cristea
2026-05-16 16:40 ` David Lechner [this message]
2026-05-16 18:21 ` Jonathan Cameron
2026-05-16 16:36 ` [PATCH v4 0/2] add support for Microchip PAC194X Power Monitor David Lechner
2026-05-17 7:04 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c1b2887-1e95-4723-b42e-329ef5b1ee90@baylibre.com \
--to=dlechner@baylibre.com \
--cc=andy@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marius.cristea@microchip.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®