From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Md Sadre Alam <quic_mdalam@quicinc.com>,
broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andersson@kernel.org,
konradybcio@kernel.org, miquel.raynal@bootlin.com,
richard@nod.at, vigneshr@ti.com,
manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Cc: quic_srichara@quicinc.com, quic_varada@quicinc.com
Subject: Re: [PATCH v14 7/8] arm64: dts: qcom: ipq9574: Add SPI nand support
Date: Thu, 5 Dec 2024 18:19:21 +0100 [thread overview]
Message-ID: <4c1fe789-5190-465d-bb41-3fe1534d2523@oss.qualcomm.com> (raw)
In-Reply-To: <20241120091507.1404368-8-quic_mdalam@quicinc.com>
On 20.11.2024 10:15 AM, Md Sadre Alam wrote:
> Add SPI NAND support for ipq9574 SoC.
>
> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
> ---
[...]
Feel free to put dt patches in a separate series after Miquel picks
up the mtd changes
> &usb_0_dwc3 {
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> index d1fd35ebc4a2..45fb26bc9480 100644
board and dtsi patches should be 2 separate ones
> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> @@ -330,6 +330,33 @@ tcsr: syscon@1937000 {
> reg = <0x01937000 0x21000>;
> };
>
> + qpic_bam: dma-controller@7984000 {
> + compatible = "qcom,bam-v1.7.0";
> + reg = <0x7984000 0x1c000>;
Please pad the address part to 8 hex digits with leading zeroes
> + interrupts = <GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&gcc GCC_QPIC_AHB_CLK>;
> + clock-names = "bam_clk";
> + #dma-cells = <1>;
> + qcom,ee = <0>;
> + status = "disabled";
> + };
> +
> + qpic_nand: spi@79b0000 {
> + compatible = "qcom,ipq9574-snand";
> + reg = <0x79b0000 0x10000>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&gcc GCC_QPIC_CLK>,
> + <&gcc GCC_QPIC_AHB_CLK>,
> + <&gcc GCC_QPIC_IO_MACRO_CLK>;
> + clock-names = "core", "aon", "iom";
> + dmas = <&qpic_bam 0>,
> + <&qpic_bam 1>,
> + <&qpic_bam 2>;
> + dma-names = "tx", "rx", "cmd";
Please make clock/dma names a vertical list, like clocks/dmas
Also, is it okay not to use any of the GCC_QPIC_BCR/
GCC_QPIC_AHB_ARES/GCC_QPIC_ARES resets found in GCC?
Konrad
next prev parent reply other threads:[~2024-12-05 17:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 9:14 [PATCH v14 0/8] Add QPIC SPI NAND driver Md Sadre Alam
2024-11-20 9:14 ` [PATCH v14 1/8] spi: dt-bindings: Introduce qcom,spi-qpic-snand Md Sadre Alam
2024-11-20 9:15 ` [PATCH v14 2/8] mtd: rawnand: qcom: cleanup qcom_nandc driver Md Sadre Alam
2024-11-20 9:15 ` [PATCH v14 3/8] mtd: rawnand: qcom: Add qcom prefix to common api Md Sadre Alam
2024-11-20 9:15 ` [PATCH v14 4/8] mtd: nand: Add qpic_common API file Md Sadre Alam
2024-11-20 9:15 ` [PATCH v14 5/8] mtd: rawnand: qcom: use FIELD_PREP and GENMASK Md Sadre Alam
2024-11-20 9:15 ` [PATCH v14 6/8] spi: spi-qpic: add driver for QCOM SPI NAND flash Interface Md Sadre Alam
2024-11-20 9:15 ` [PATCH v14 7/8] arm64: dts: qcom: ipq9574: Add SPI nand support Md Sadre Alam
2024-12-05 17:19 ` Konrad Dybcio [this message]
2024-12-09 5:32 ` Md Sadre Alam
2024-11-20 9:15 ` [PATCH v14 8/8] arm64: dts: qcom: ipq9574: Remove eMMC node Md Sadre Alam
2024-12-05 17:19 ` Konrad Dybcio
2024-12-02 16:57 ` [PATCH v14 0/8] Add QPIC SPI NAND driver Miquel Raynal
2024-12-03 11:04 ` Md Sadre Alam
2024-12-23 19:14 ` Miquel Raynal
2024-12-24 5:07 ` Md Sadre Alam
2024-12-24 15:43 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c1fe789-5190-465d-bb41-3fe1534d2523@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=miquel.raynal@bootlin.com \
--cc=quic_mdalam@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®