Re: [PATCH v3 1/2] media: iris: force stage 1 work mode for CBR RC on encoder

[Sachin Kumar Garg <sachin.garg@oss.qualcomm.com>]

On 7/22/2026 3:17 AM, Dmitry Baryshkov wrote:
> On Tue, Jul 21, 2026 at 03:23:32PM +0530, Sachin Kumar Garg wrote:
>> iris_set_stage() currently always picks STAGE_2 for encoder sessions.
>> CBR rate control requires stage 1 operation, so force STAGE_1 when
>> BITRATE_MODE is set to CBR.
>>
>> The BITRATE_MODE fw_cap value is used instead of inst->hfi_rc_type
>> since STAGE precedes BITRATE_MODE in enum platform_inst_fw_cap_type,
>> so iris_set_properties() would still see the previous hfi_rc_type
>> when iris_set_stage() runs during initial config
>>
>> Reviewed-by: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
>> Signed-off-by: Sachin Kumar Garg <sachin.garg@oss.qualcomm.com>
>> ---
>>   drivers/media/platform/qcom/iris/iris_ctrls.c | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c b/drivers/media/platform/qcom/iris/iris_ctrls.c
>> index 10e33b8a73f6..d7cbf6c3614a 100644
>> --- a/drivers/media/platform/qcom/iris/iris_ctrls.c
>> +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c
>> @@ -519,8 +519,13 @@ int iris_set_stage(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id
>>   	if (inst->domain == DECODER) {
>>   		if (iris_res_is_less_than(width, height, 1280, 720))
>>   			work_mode = STAGE_1;
>> +	} else if (inst->domain == ENCODER) {
>> +		if (inst->fw_caps[BITRATE_MODE].value == V4L2_MPEG_VIDEO_BITRATE_MODE_CBR)
>> +			work_mode = STAGE_1;
>>   	}
>>   
>> +	inst->fw_caps[cap_id].value = work_mode;
> 
> Separate commit, Fixes tag.
> 

Thanks, Dmitry. Agreed — this is fixed in v4: split into a separate 
patch ("cache work mode after computing it in iris_set_stage") with a 
fixes tag.

>> +
>>   	return hfi_ops->session_set_property(inst, hfi_id,
>>   					     HFI_HOST_FLAGS_NONE,
>>   					     iris_get_port_info(inst, cap_id),
>>
>> -- 
>> 2.34.1
>>
>