Re: [RESEND PATCH] arm64: dts: mediatek: Fix "status" values

Re: [RESEND PATCH] arm64: dts: mediatek: Fix "status" values

[AngeloGioacchino Del Regno]

Il 05/08/23 00:58, Rob Herring ha scritto:
> The defined value for "status" is "disabled", not "disable".
> 
> Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Arnd, Please take this directly I guess. I think Mediatek maintainership
> needs some help. Maybe AngeloGioacchino should be co-maintainer as
> that's the only response I seem to be getting.

Sorry but I've seen this message just now as I've been on holiday in August.

Thing is, the MediaTek scene is starting to see more and more code, bringing
an obvious increase in the amount of reviews to be done and in the required
efforts to maintain the MTK bits - and we will possibly (hopefully) see even
more of that.

If Matthias needs/wants a co-maintainer for MediaTek I'm here and I will be
proud to become one.

Cheers,
Angelo

> 
> I think for future .dts patches I will not bother splitting them up by
> sub-arch because it's a pain to chase down the maintainers to apply
> stuff in a timely manner. /rant
> 
>   arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> index e4605d23fdc8..86cedb0bf1a9 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> @@ -585,11 +585,11 @@ &pwrap {
>   };
>   
>   &sata {
> -	status = "disable";
> +	status = "disabled";
>   };
>   
>   &sata_phy {
> -	status = "disable";
> +	status = "disabled";
>   };
>   
>   &spi0 {

Re: [RESEND PATCH] arm64: dts: mediatek: Fix "status" values

[Alexandre Mergnat]

On 12/09/2023 14:54, AngeloGioacchino Del Regno wrote:
> Il 05/08/23 00:58, Rob Herring ha scritto:
>> The defined value for "status" is "disabled", not "disable".
>>
>> Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
>> Reviewed-by: AngeloGioacchino Del Regno 
>> <angelogioacchino.delregno@collabora.com>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> ---
>> Arnd, Please take this directly I guess. I think Mediatek maintainership
>> needs some help. Maybe AngeloGioacchino should be co-maintainer as
>> that's the only response I seem to be getting.
> 
> Sorry but I've seen this message just now as I've been on holiday in 
> August.
> 
> Thing is, the MediaTek scene is starting to see more and more code, 
> bringing
> an obvious increase in the amount of reviews to be done and in the required
> efforts to maintain the MTK bits - and we will possibly (hopefully) see 
> even
> more of that.
> 
> If Matthias needs/wants a co-maintainer for MediaTek I'm here and I will be
> proud to become one.
> 
> Cheers,
> Angelo
> 

I started reviewing MediaTek patches for some months now, so I'm still 
new. From my PoV, I'm agree with Angelo when he say the amount of patch 
is increasing. I support Angelo if he wants to become a co-maintainer 
and continue to do my best to review patches. ;)

>>
>> I think for future .dts patches I will not bother splitting them up by
>> sub-arch because it's a pain to chase down the maintainers to apply
>> stuff in a timely manner. /rant
>>
>>   arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts 
>> b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
>> index e4605d23fdc8..86cedb0bf1a9 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
>> @@ -585,11 +585,11 @@ &pwrap {
>>   };
>>   &sata {
>> -    status = "disable";
>> +    status = "disabled";
>>   };
>>   &sata_phy {
>> -    status = "disable";
>> +    status = "disabled";
>>   };
>>   &spi0 {
> 
> 

-- 
Regards,
Alexandre

Re: [RESEND PATCH] arm64: dts: mediatek: Fix "status" values

[Chen-Yu Tsai]

On Tue, Sep 12, 2023 at 9:10 PM Alexandre Mergnat <amergnat@baylibre.com> wrote:
>
>
>
> On 12/09/2023 14:54, AngeloGioacchino Del Regno wrote:
> > Il 05/08/23 00:58, Rob Herring ha scritto:
> >> The defined value for "status" is "disabled", not "disable".
> >>
> >> Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
> >> Reviewed-by: AngeloGioacchino Del Regno
> >> <angelogioacchino.delregno@collabora.com>
> >> Signed-off-by: Rob Herring <robh@kernel.org>
> >> ---
> >> Arnd, Please take this directly I guess. I think Mediatek maintainership
> >> needs some help. Maybe AngeloGioacchino should be co-maintainer as
> >> that's the only response I seem to be getting.
> >
> > Sorry but I've seen this message just now as I've been on holiday in
> > August.
> >
> > Thing is, the MediaTek scene is starting to see more and more code,
> > bringing
> > an obvious increase in the amount of reviews to be done and in the required
> > efforts to maintain the MTK bits - and we will possibly (hopefully) see
> > even
> > more of that.
> >
> > If Matthias needs/wants a co-maintainer for MediaTek I'm here and I will be
> > proud to become one.
> >
> > Cheers,
> > Angelo
> >
>
> I started reviewing MediaTek patches for some months now, so I'm still
> new. From my PoV, I'm agree with Angelo when he say the amount of patch
> is increasing. I support Angelo if he wants to become a co-maintainer
> and continue to do my best to review patches. ;)

I might not have enough time to do a lot of reviews, but if help is needed
for administrative tasks like queueing patches and sending pull requests,
that's something I can do.

ChenYu

> >>
> >> I think for future .dts patches I will not bother splitting them up by
> >> sub-arch because it's a pain to chase down the maintainers to apply
> >> stuff in a timely manner. /rant
> >>
> >>   arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts | 4 ++--
> >>   1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> >> b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> >> index e4605d23fdc8..86cedb0bf1a9 100644
> >> --- a/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> >> +++ b/arch/arm64/boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts
> >> @@ -585,11 +585,11 @@ &pwrap {
> >>   };
> >>   &sata {
> >> -    status = "disable";
> >> +    status = "disabled";
> >>   };
> >>   &sata_phy {
> >> -    status = "disable";
> >> +    status = "disabled";
> >>   };
> >>   &spi0 {
> >
> >
>
> --
> Regards,
> Alexandre
>