From: "Nitin Gupta" <nitingupta910@gmail.com>
To: "Michael-Luke Jones" <mlj28@cam.ac.uk>
Cc: linux-kernel@vger.kernel.org,
"Richard Purdie" <richard@openedhand.com>,
linux-mm-cc@laptop.org
Subject: Re: [RFC] LZO de/compression support - take 3
Date: Wed, 23 May 2007 19:33:36 +0530 [thread overview]
Message-ID: <4cefeab80705230703vdb3c414s250a61c4c2d70c51@mail.gmail.com> (raw)
In-Reply-To: <624FD7A7-5552-415F-96D8-4353453EA2A3@cam.ac.uk>
On 5/23/07, Michael-Luke Jones <mlj28@cam.ac.uk> wrote:
>
> Fair enough. However, this rather important issue is pretty much
> undocumented (source code comments don't count)
If header file for public interface (<linux/lzo1x.h> documents about
'unsafe' vs. 'safe' then it should be enough.
> and Reiser4 is
> already using the lzo1x_decompress() function rather than the
> seemingly more appropriate lzo1x_decompress_safe() function...
>
> http://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-
> rc2/2.6.22-rc2-mm1/broken-out/reiser4-use-lzo-library-functions.patch
>
> Perhaps a rename is in order:
> lzo1x_decompress() => lzo1x_decompress_unsafe()
> lzo1x_decompress_safe => lzo1x_decompress()
>
Or perhaps make reiserfs use _safe() instead - I think Richard has
already submitted patch for same.
- Nitin
next prev parent reply other threads:[~2007-05-23 14:03 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-23 8:27 Nitin Gupta
2007-05-23 10:53 ` Michael-Luke Jones
2007-05-23 11:39 ` Nitin Gupta
2007-05-23 13:57 ` Michael-Luke Jones
2007-05-23 14:03 ` Nitin Gupta [this message]
2007-05-23 14:10 ` Michael-Luke Jones
2007-05-23 14:21 ` Nitin Gupta
2007-05-23 14:33 ` Michael-Luke Jones
2007-05-24 22:41 ` Richard Purdie
2007-05-24 22:54 ` Andrew Morton
2007-05-24 23:00 ` Richard Purdie
2007-05-23 16:16 ` Andrew Morton
2007-05-23 16:49 ` Richard Purdie
2007-05-24 4:04 ` Nitin Gupta
2007-05-25 10:42 ` Pavel Machek
2007-05-26 10:23 ` Michael-Luke Jones
2007-05-26 11:17 ` Nitin Gupta
2007-05-23 14:50 ` Bret Towe
2007-05-24 13:48 ` Nitin Gupta
2007-05-25 2:38 ` Bret Towe
2007-05-25 5:10 ` Nitin Gupta
2007-05-25 17:02 ` Bret Towe
2007-05-25 17:33 ` Nitin Gupta
2007-05-26 11:30 ` Nitin Gupta
2007-05-27 3:39 ` Bret Towe
2007-05-23 19:34 ` Satyam Sharma
2007-05-24 4:37 ` Nitin Gupta
2007-05-24 10:49 ` Satyam Sharma
2007-05-24 8:25 ` Richard Purdie
2007-05-24 11:07 ` Satyam Sharma
2007-05-24 14:29 ` Nitin Gupta
2007-05-24 19:12 ` Satyam Sharma
2007-05-24 14:20 ` Nitin Gupta
2007-05-24 20:09 ` Satyam Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cefeab80705230703vdb3c414s250a61c4c2d70c51@mail.gmail.com \
--to=nitingupta910@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm-cc@laptop.org \
--cc=mlj28@cam.ac.uk \
--cc=richard@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®