* [PATCH] media: vb2 dma-sg: Constify dma_buf_ops structures.
@ 2017-07-01 12:18 ` Arvind Yadav
2017-07-04 5:23 ` Marek Szyprowski
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-07-01 12:18 UTC (permalink / raw)
To: pawel, m.szyprowski, kyungmin.park, mchehab; +Cc: linux-media, linux-kernel
dma_buf_ops are not supposed to change at runtime. All functions
working with dma_buf_ops provided by <linux/dma-buf.h> work with
const dma_buf_ops. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
5238 112 4 5354 14ea drivers/media/v4l2-core/videobuf2-dma-sg.o
File size After adding 'const':
text data bss dec hex filename
5358 0 4 5362 14f2 drivers/media/v4l2-core/videobuf2-dma-sg.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/media/v4l2-core/videobuf2-dma-sg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/videobuf2-dma-sg.c b/drivers/media/v4l2-core/videobuf2-dma-sg.c
index 8e8798a..f8b4643 100644
--- a/drivers/media/v4l2-core/videobuf2-dma-sg.c
+++ b/drivers/media/v4l2-core/videobuf2-dma-sg.c
@@ -500,7 +500,7 @@ static int vb2_dma_sg_dmabuf_ops_mmap(struct dma_buf *dbuf,
return vb2_dma_sg_mmap(dbuf->priv, vma);
}
-static struct dma_buf_ops vb2_dma_sg_dmabuf_ops = {
+static const struct dma_buf_ops vb2_dma_sg_dmabuf_ops = {
.attach = vb2_dma_sg_dmabuf_ops_attach,
.detach = vb2_dma_sg_dmabuf_ops_detach,
.map_dma_buf = vb2_dma_sg_dmabuf_ops_map,
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] media: vb2 dma-sg: Constify dma_buf_ops structures.
2017-07-01 12:18 ` [PATCH] media: vb2 dma-sg: Constify dma_buf_ops structures Arvind Yadav
@ 2017-07-04 5:23 ` Marek Szyprowski
0 siblings, 0 replies; 2+ messages in thread
From: Marek Szyprowski @ 2017-07-04 5:23 UTC (permalink / raw)
To: Arvind Yadav, pawel, kyungmin.park, mchehab; +Cc: linux-media, linux-kernel
Hi Arvind,
On 2017-07-01 14:18, Arvind Yadav wrote:
> dma_buf_ops are not supposed to change at runtime. All functions
> working with dma_buf_ops provided by <linux/dma-buf.h> work with
> const dma_buf_ops. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 5238 112 4 5354 14ea drivers/media/v4l2-core/videobuf2-dma-sg.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 5358 0 4 5362 14f2 drivers/media/v4l2-core/videobuf2-dma-sg.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/media/v4l2-core/videobuf2-dma-sg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/v4l2-core/videobuf2-dma-sg.c b/drivers/media/v4l2-core/videobuf2-dma-sg.c
> index 8e8798a..f8b4643 100644
> --- a/drivers/media/v4l2-core/videobuf2-dma-sg.c
> +++ b/drivers/media/v4l2-core/videobuf2-dma-sg.c
> @@ -500,7 +500,7 @@ static int vb2_dma_sg_dmabuf_ops_mmap(struct dma_buf *dbuf,
> return vb2_dma_sg_mmap(dbuf->priv, vma);
> }
>
> -static struct dma_buf_ops vb2_dma_sg_dmabuf_ops = {
> +static const struct dma_buf_ops vb2_dma_sg_dmabuf_ops = {
> .attach = vb2_dma_sg_dmabuf_ops_attach,
> .detach = vb2_dma_sg_dmabuf_ops_detach,
> .map_dma_buf = vb2_dma_sg_dmabuf_ops_map,
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-04 5:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170701121836epcas4p10697c89a407bd22152d3e31a967b5b90@epcas4p1.samsung.com>
2017-07-01 12:18 ` [PATCH] media: vb2 dma-sg: Constify dma_buf_ops structures Arvind Yadav
2017-07-04 5:23 ` Marek Szyprowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®