From: David Lechner <dlechner@baylibre.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: temperature: maxim_thermocouple: use IIO_DECLARE_DMA_BUFFER_WITH_TS()
Date: Fri, 11 Jul 2025 13:38:17 -0500 [thread overview]
Message-ID: <4d41eafc-46b1-48c7-982a-1a3566f9b423@baylibre.com> (raw)
In-Reply-To: <aHFO7LhWXOuglaoz@smile.fi.intel.com>
On 7/11/25 12:50 PM, Andy Shevchenko wrote:
> On Fri, Jul 11, 2025 at 12:04:03PM -0500, David Lechner wrote:
>> On 7/11/25 11:41 AM, Andy Shevchenko wrote:
>>> On Fri, Jul 11, 2025 at 10:33:55AM -0500, David Lechner wrote:
>
> ...
>
>>>> +#include <asm/byteorder.h>
>>>
>>> Hmm... I see nothing about this change in the commit message.
>>
>> It is for __be16. I kind of assumed that would be obvious, but sure,
>> better to be explicit about it.
>
> Isn't it in types.h?
>
No, only CPU-endian types are in types.h. The actual #define for
__be16 is in include/uapi/linux/byteorder/big_endian.h. This is
included in one driver in staging, otherwise it is only included
in arch/*/include/uapi/asm/byteorder.h. And asm/byteorder.h is what
Jonathan used for similar in some of his recent IWYU patches as well,
so I assume that is the preferred way to do it.
next prev parent reply other threads:[~2025-07-11 18:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 15:33 David Lechner
2025-07-11 16:41 ` Andy Shevchenko
2025-07-11 17:04 ` David Lechner
2025-07-11 17:50 ` Andy Shevchenko
2025-07-11 18:38 ` David Lechner [this message]
2025-07-11 18:50 ` Andy Shevchenko
2025-07-11 19:26 ` David Lechner
2025-07-13 14:10 ` Jonathan Cameron
2025-07-13 16:26 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d41eafc-46b1-48c7-982a-1a3566f9b423@baylibre.com \
--to=dlechner@baylibre.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®