Re: [PATCH] iio: temperature: maxim_thermocouple: use IIO_DECLARE_DMA_BUFFER_WITH_TS()

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Fri, Jul 11, 2025 at 01:38:17PM -0500, David Lechner wrote:
> On 7/11/25 12:50 PM, Andy Shevchenko wrote:
> > On Fri, Jul 11, 2025 at 12:04:03PM -0500, David Lechner wrote:
> >> On 7/11/25 11:41 AM, Andy Shevchenko wrote:
> >>> On Fri, Jul 11, 2025 at 10:33:55AM -0500, David Lechner wrote:

...

> >>>> +#include <asm/byteorder.h>
> >>>
> >>> Hmm... I see nothing about this change in the commit message.
> >>
> >> It is for __be16. I kind of assumed that would be obvious, but sure,
> >> better to be explicit about it.
> > 
> > Isn't it in types.h?
> 
> No, only CPU-endian types are in types.h. The actual #define for
>  __be16 is in include/uapi/linux/byteorder/big_endian.h.

Huh?!

> This is
> included in one driver in staging, otherwise it is only included
> in arch/*/include/uapi/asm/byteorder.h. And asm/byteorder.h is what
> Jonathan used for similar in some of his recent IWYU patches as well,
> so I assume that is the preferred way to do it.

include/uapi/linux/types.h:37:typedef __u16 __bitwise __be16;

-- 
With Best Regards,
Andy Shevchenko