* [PATCH] scsi: aic7xxx: avoid checkpatch error
[not found] <20230720095619.3954-1-xujianghui@cdjrlc.com>
@ 2023-07-20 9:57 ` sunran001
2023-07-20 11:23 ` James Bottomley
0 siblings, 1 reply; 2+ messages in thread
From: sunran001 @ 2023-07-20 9:57 UTC (permalink / raw)
To: hare, jejb, martin.petersen; +Cc: linux-scsi, linux-kernel
ERROR: do not initialise statics to NULL
Signed-off-by: Ran Sun <sunran001@208suo.com>
---
drivers/scsi/aic7xxx/aic7xxx_osm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c
b/drivers/scsi/aic7xxx/aic7xxx_osm.c
index d3b1082654d5..c062bf27b55a 100644
--- a/drivers/scsi/aic7xxx/aic7xxx_osm.c
+++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c
@@ -124,7 +124,7 @@
#include "aic7xxx_inline.h"
#include <scsi/scsicam.h>
-static struct scsi_transport_template *ahc_linux_transport_template =
NULL;
+static struct scsi_transport_template *ahc_linux_transport_template;
#include <linux/init.h> /* __setup */
#include <linux/mm.h> /* For fetching system memory size */
@@ -325,7 +325,7 @@ static uint32_t aic7xxx_periodic_otag;
/*
* Module information and settable options.
*/
-static char *aic7xxx = NULL;
+static char *aic7xxx;
MODULE_AUTHOR("Maintainer: Hannes Reinecke <hare@suse.de>");
MODULE_DESCRIPTION("Adaptec AIC77XX/78XX SCSI Host Bus Adapter
driver");
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: aic7xxx: avoid checkpatch error
2023-07-20 9:57 ` [PATCH] scsi: aic7xxx: avoid checkpatch error sunran001
@ 2023-07-20 11:23 ` James Bottomley
0 siblings, 0 replies; 2+ messages in thread
From: James Bottomley @ 2023-07-20 11:23 UTC (permalink / raw)
To: sunran001, hare, martin.petersen; +Cc: linux-scsi, linux-kernel
On Thu, 2023-07-20 at 17:57 +0800, sunran001@208suo.com wrote:
> ERROR: do not initialise statics to NULL
We don't accept checkpatch fixes on drivers, particularly not old ones.
The reason is very simple: checkpatch keeps updating, so they would
cause endless churn and a vastly increased risk of introducing bugs
into older drivers. Checkpatch.pl as the name implies is for checking
patches only.
James
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-20 11:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230720095619.3954-1-xujianghui@cdjrlc.com>
2023-07-20 9:57 ` [PATCH] scsi: aic7xxx: avoid checkpatch error sunran001
2023-07-20 11:23 ` James Bottomley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome