mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Christopher Obbard <chris.obbard@collabora.com>,
	Michael Riesch <michael.riesch@wolfvision.net>,
	Sebastian Reichel <sebastian.reichel@collabora.com>,
	Shreeya Patel <shreeya.patel@collabora.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	kernel@collabora.com
Subject: Re: [PATCH 2/3] arm64: dts: rockchip: Use generic name for es8316 on rk3588-rock-5b
Date: Fri, 14 Apr 2023 13:53:56 +0300	[thread overview]
Message-ID: <4d66fb01-76da-be30-26dd-908ee1a22eb1@collabora.com> (raw)
In-Reply-To: <fe746692-fed3-6635-8658-4e91d30f2aa8@linaro.org>

On 4/14/23 13:26, Krzysztof Kozlowski wrote:
> On 14/04/2023 11:34, Cristian Ciocaltea wrote:
>> Use generic 'audio-codec' name for es8316 node on Rock 5B board.
>>
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>> ---
>>  arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>> index 62750beb12aa..8cc97d146a73 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
>> @@ -72,7 +72,7 @@ hym8563: rtc@51 {
>>  &i2c7 {
>>  	status = "okay";
>>  
>> -	es8316: es8316@11 {
>> +	es8316: audio-codec@11 {
> 
> This is a trivial change. Fix all instances in all subarch/platform DTS.
> Not board-per-board.

Looks like only the rockchip DTS are affected, but not quite sure how to 
proceed in the case of 'es8316: codec@', should I change them to 
'es8316: audio-codec@' as well?

arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts:   es8316: es8316@11 {
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi:     es8316: codec@11 {
arch/arm64/boot/dts/rockchip/rk3399-rockpro64-v2.dts:   es8316: codec@10 {
arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts:      es8316: codec@11 {

  reply	other threads:[~2023-04-14 10:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-14  9:34 [PATCH 0/3] Add regulators to Rock 5B's CPU big cores Cristian Ciocaltea
2023-04-14  9:34 ` [PATCH 1/3] arm64: dts: rockchip: Drop RTC clock-frequency on rk3588-rock-5b Cristian Ciocaltea
2023-04-14  9:34 ` [PATCH 2/3] arm64: dts: rockchip: Use generic name for es8316 " Cristian Ciocaltea
2023-04-14 10:26   ` Krzysztof Kozlowski
2023-04-14 10:53     ` Cristian Ciocaltea [this message]
2023-04-14 11:28       ` Krzysztof Kozlowski
2023-04-14  9:34 ` [PATCH 3/3] arm64: dts: rockchip: Add vdd_cpu_big regulators to rk3588-rock-5b Cristian Ciocaltea
2023-04-14 10:27   ` Krzysztof Kozlowski
2023-04-14 10:40     ` Cristian Ciocaltea
2023-04-14 11:29       ` Krzysztof Kozlowski
2023-04-14 12:16         ` Cristian Ciocaltea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d66fb01-76da-be30-26dd-908ee1a22eb1@collabora.com \
    --to=cristian.ciocaltea@collabora.com \
    --cc=chris.obbard@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=kernel@collabora.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=michael.riesch@wolfvision.net \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=shreeya.patel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®