From: Brijesh Singh <brijesh.singh@amd.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>,
Borislav Petkov <bp@suse.de>
Cc: brijesh.singh@amd.com, Paolo Bonzini <pbonzini@redhat.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Lendacky, Thomas" <Thomas.Lendacky@amd.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: SEV guest regression in 4.18
Date: Wed, 22 Aug 2018 15:11:20 -0500 [thread overview]
Message-ID: <4d6ee892-a34f-28b3-18b7-1c663eb281c6@amd.com> (raw)
In-Reply-To: <20180822150033.GA14200@linux.intel.com>
Hi Sean,
On 08/22/2018 10:00 AM, Sean Christopherson wrote:
> On Wed, Aug 22, 2018 at 10:14:17AM +0200, Borislav Petkov wrote:
>> Dropping Pavel as it bounces.
>>
>> On Tue, Aug 21, 2018 at 11:07:38AM -0500, Brijesh Singh wrote:
>>> The tsc_early_init() is called before setup_arch() -> init_mem_mapping.
>>
>> Ok, I see it, thanks for explaining.
>>
>> So back to your original ideas - I'm wondering whether we should define
>> a chunk of memory which the hypervisor and guest can share and thus
>> communicate over... Something ala SEV-ES also with strictly defined
>> layout and put all those variables there. And then the guest can map
>> decrypted.
>
> What about creating a data section specifically for shared memory?
> The section would be PMD aligned and sized so that it could be mapped
> appropriately without having to fracture the page. Then define a
> macro to easily declare data in the new section, a la __read_mostly.
>
Yes, this is one of approach I have in mind. It will avoid splitting
the larger pages; I am thinking that early in boot code we can lookup
for this special section and decrypt it in-place and probably maps with
C=0. Only downside, it will increase data section footprint a bit
because we need to align this section to PM_SIZE.
>> There might be something similar though, I dunno.
>>
>> Maybe Paolo has a better idea...
>>
>> --
>> Regards/Gruss,
>> Boris.
>>
>> SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
>> --
next prev parent reply other threads:[~2018-08-22 20:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-20 22:11 Brijesh Singh
2018-08-21 8:39 ` Borislav Petkov
2018-08-21 14:37 ` Brijesh Singh
2018-08-21 15:19 ` Borislav Petkov
2018-08-21 16:07 ` Brijesh Singh
2018-08-22 8:14 ` Borislav Petkov
2018-08-22 15:00 ` Sean Christopherson
2018-08-22 20:11 ` Brijesh Singh [this message]
2018-08-23 11:26 ` Paolo Bonzini
2018-08-23 15:29 ` Sean Christopherson
2018-08-23 16:16 ` Paolo Bonzini
2018-08-24 15:41 ` Brijesh Singh
2018-08-24 15:50 ` Paolo Bonzini
2018-08-24 18:47 ` Brijesh Singh
2018-08-25 4:47 ` Borislav Petkov
2018-08-24 16:24 ` Sean Christopherson
2018-08-24 18:48 ` Brijesh Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d6ee892-a34f-28b3-18b7-1c663eb281c6@amd.com \
--to=brijesh.singh@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=bp@suse.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®