From: Ping-Ke Shih <pkshih@realtek.com>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "kvalo@kernel.org" <kvalo@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel@gpiccoli.net" <kernel@gpiccoli.net>,
"kernel-dev@igalia.com" <kernel-dev@igalia.com>,
"rtl8821cerfe2@gmail.com" <rtl8821cerfe2@gmail.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"syzbot+edd9fe0d3a65b14588d5@syzkaller.appspotmail.com"
<syzbot+edd9fe0d3a65b14588d5@syzkaller.appspotmail.com>
Subject: Re: [PATCH V2] wifi: rtlwifi: Drastically reduce the attempts to read efuse in case of failures
Date: Thu, 31 Oct 2024 02:15:38 +0000 [thread overview]
Message-ID: <4d9471f600224d23bb1f49a8ed4943c2@realtek.com> (raw)
In-Reply-To: <20241030141440.1153887-1-gpiccoli@igalia.com>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/efuse.c b/drivers/net/wireless/realtek/rtlwifi/efuse.c
> index 82cf5fb5175f..f741066c06de 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/efuse.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/efuse.c
> @@ -164,7 +164,17 @@ void read_efuse_byte(struct ieee80211_hw *hw, u16 _offset, u8 *pbuf)
> struct rtl_priv *rtlpriv = rtl_priv(hw);
> u32 value32;
> u8 readbyte;
> - u16 retry;
> + u16 retry, max_attempts;
> +
Declarations should be in reverse X'mas tree order.
Just add max_attempts to a new line at proper position.
next prev parent reply other threads:[~2024-10-31 2:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 14:09 Guilherme G. Piccoli
2024-10-31 2:15 ` Ping-Ke Shih [this message]
2024-10-31 16:00 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d9471f600224d23bb1f49a8ed4943c2@realtek.com \
--to=pkshih@realtek.com \
--cc=gpiccoli@igalia.com \
--cc=kernel-dev@igalia.com \
--cc=kernel@gpiccoli.net \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
--cc=stable@vger.kernel.org \
--cc=syzbot+edd9fe0d3a65b14588d5@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®