mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: "kvalo@kernel.org" <kvalo@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kernel@gpiccoli.net" <kernel@gpiccoli.net>,
	"kernel-dev@igalia.com" <kernel-dev@igalia.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"rtl8821cerfe2@gmail.com" <rtl8821cerfe2@gmail.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"syzbot+edd9fe0d3a65b14588d5@syzkaller.appspotmail.com"
	<syzbot+edd9fe0d3a65b14588d5@syzkaller.appspotmail.com>
Subject: Re: [PATCH V2] wifi: rtlwifi: Drastically reduce the attempts to read efuse in case of failures
Date: Thu, 31 Oct 2024 13:00:16 -0300	[thread overview]
Message-ID: <fcd4858d-244a-d491-7c22-4231a654ca81@igalia.com> (raw)
In-Reply-To: <4d9471f600224d23bb1f49a8ed4943c2@realtek.com>

On 30/10/2024 23:15, Ping-Ke Shih wrote:
> 
>> diff --git a/drivers/net/wireless/realtek/rtlwifi/efuse.c b/drivers/net/wireless/realtek/rtlwifi/efuse.c
>> index 82cf5fb5175f..f741066c06de 100644
>> --- a/drivers/net/wireless/realtek/rtlwifi/efuse.c
>> +++ b/drivers/net/wireless/realtek/rtlwifi/efuse.c
>> @@ -164,7 +164,17 @@ void read_efuse_byte(struct ieee80211_hw *hw, u16 _offset, u8 *pbuf)
>>         struct rtl_priv *rtlpriv = rtl_priv(hw);
>>         u32 value32;
>>         u8 readbyte;
>> -       u16 retry;
>> +       u16 retry, max_attempts;
>> +
> 
> Declarations should be in reverse X'mas tree order.
> Just add max_attempts to a new line at proper position. 

Thanks, V3 just sent:
https://lore.kernel.org/r/20241031155731.1253259-1-gpiccoli@igalia.com/

      reply	other threads:[~2024-10-31 16:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30 14:09 Guilherme G. Piccoli
2024-10-31  2:15 ` Ping-Ke Shih
2024-10-31 16:00   ` Guilherme G. Piccoli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcd4858d-244a-d491-7c22-4231a654ca81@igalia.com \
    --to=gpiccoli@igalia.com \
    --cc=kernel-dev@igalia.com \
    --cc=kernel@gpiccoli.net \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    --cc=rtl8821cerfe2@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=syzbot+edd9fe0d3a65b14588d5@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®