mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vikash Garodia <quic_vgarodia@quicinc.com>
To: Johan Hovold <johan@kernel.org>,
	Stefan Schmidt <stefan.schmidt@linaro.org>
Cc: "Dikshita Agarwal" <quic_dikshita@quicinc.com>,
	"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Hans Verkuil" <hverkuil@xs4all.nl>,
	"Sebastian Fricke" <sebastian.fricke@collabora.com>,
	"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
	"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Nicolas Dufresne" <nicolas@ndufresne.ca>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	"Jianhua Lu" <lujianhua000@gmail.com>,
	linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Vedang Nagar" <quic_vnagar@quicinc.com>,
	"Bjorn Andersson" <andersson@kernel.org>
Subject: Re: [PATCH v9 00/28] Qualcomm iris video decoder driver
Date: Mon, 3 Feb 2025 14:57:58 +0530	[thread overview]
Message-ID: <4dab19d0-22eb-2395-56fd-758c3c0d8bc7@quicinc.com> (raw)
In-Reply-To: <Z6CBrMus4SdSG9oF@hovoldconsulting.com>


On 2/3/2025 2:13 PM, Johan Hovold wrote:
> On Wed, Jan 22, 2025 at 04:34:51PM +0100, Stefan Schmidt wrote:
>> On Thu, 9 Jan 2025 at 15:58, Johan Hovold <johan@kernel.org> wrote:
>>> On Thu, Dec 12, 2024 at 05:21:22PM +0530, Dikshita Agarwal wrote:
> 
>>>> Introduce support for Qualcomm new video acceleration hardware i.e.
>>>> iris, used for video stream decoding.
>>>
>>>> Note: A harmless onetime error log "Lucid PLL latch failed. Output may
>>>> be unstable!" is seen during bootup.  It doesn't impact any video
>>>> usecase and is currently under discussion.
>>>
>>> This could be an indication that some resources are not described
>>> correctly and could potentially require both binding and driver changes
>>> to address.
>>>
>>> This is also something which could cause trouble later (e.g. during
>>> suspend) even if you manage to get the clock running after boot.
>>>
>>> Generally, you should not be introducing any new warnings; they are
>>> there to let you know that something is wrong.
>>>
>>> Where is this issue being discussed?
>>>
>>> I think we at least need a public analysis and understanding of the
>>> problem before merging this.
>>
>> Taniya Das proposed a patchset to reconfigure PLL in the clk-alpha-pll
>> which allows the videocc-sm8550 driver to configure it correctly.
>> https://lore.kernel.org/linux-arm-msm/20250113-support-pll-reconfigure-v1-0-1fae6bc1062d@quicinc.com/T/
>>
>> I tested the Iris driver with this patchset and I am no longer seeing
>> the Lucid PLL latch failed warning.
> 
> Thanks for the pointer. Please make sure to reference this series (and
> summarise the underlying issue) when resending this series.
> 
> Judging from a quick look the approach taken there seems like a bit of a
> hack so it may not get merged in its current form. IIUC fixing the PLL
> issue properly may depend on adding support for multiple power domains
> to the clock drivers.
It would be good if you can add your comment to the PLL fix series [1] so that
the patch owner can discuss on your suggestion.
Regards,
Vikash

[1]
https://lore.kernel.org/linux-arm-msm/20250113-support-pll-reconfigure-v1-0-1fae6bc1062d@quicinc.com/T/

  reply	other threads:[~2025-02-03  9:28 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-12 11:51 Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 01/28] dt-bindings: media: Add video support for QCOM SM8550 SoC Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 02/28] media: iris: add platform driver for iris video device Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 03/28] media: iris: implement iris v4l2 file ops Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 04/28] media: iris: introduce iris core state management with shared queues Dikshita Agarwal
2025-01-15 12:45   ` Markus Elfring
2024-12-12 11:51 ` [PATCH v9 05/28] media: iris: implement video firmware load/unload Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 06/28] media: iris: implement boot sequence of the firmware Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 07/28] media: iris: introduce host firmware interface with necessary hooks Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 08/28] media: iris: implement power management Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 09/28] media: iris: implement reqbuf ioctl with vb2_queue_setup Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 10/28] media: iris: implement s_fmt, g_fmt and try_fmt ioctls Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 11/28] media: iris: implement g_selection ioctl Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 12/28] media: iris: implement enum_fmt and enum_framesizes ioctls Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 13/28] media: iris: implement subscribe_event and unsubscribe_event ioctls Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 14/28] media: iris: implement iris v4l2_ctrl_ops Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 15/28] media: iris: implement query_cap ioctl Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 16/28] media: iris: implement vb2 streaming ops Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 17/28] media: iris: implement set properties to firmware during streamon Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 18/28] media: iris: subscribe parameters and properties to firmware for hfi_gen2 Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 19/28] media: iris: allocate, initialize and queue internal buffers Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 20/28] media: iris: implement vb2 ops for buf_queue and firmware response Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 21/28] media: iris: add support for dynamic resolution change Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 22/28] media: iris: handle streamoff/on from client in " Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 23/28] media: iris: add support for drain sequence Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 24/28] media: iris: add check whether the video session is supported or not Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 25/28] media: iris: implement power scaling for vpu2 and vpu3 Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 26/28] media: iris: add check to allow sub states transitions Dikshita Agarwal
2024-12-12 11:51 ` [PATCH v9 27/28] media: iris: enable video driver probe of SM8250 SoC Dikshita Agarwal
2024-12-23 10:30   ` Mauro Carvalho Chehab
2024-12-23 10:51     ` Dikshita Agarwal
2025-01-07 13:57       ` Nicolas Dufresne
2025-01-08  7:43         ` Dikshita Agarwal
2025-01-08  7:47           ` Hans Verkuil
2025-01-08  8:51             ` Dikshita Agarwal
2025-01-08  8:55               ` Hans Verkuil
2025-01-08 10:21                 ` Dikshita Agarwal
2025-01-08 10:43                   ` Hans Verkuil
2025-01-08 11:12                     ` Dikshita Agarwal
2025-01-08 14:52                       ` Mauro Carvalho Chehab
2025-01-09  8:43                         ` Dikshita Agarwal
2025-01-09  9:49                           ` Stanimir Varbanov
2025-01-09 10:37                             ` Hans Verkuil
2025-01-09 15:11   ` Johan Hovold
2025-01-09 17:48     ` Vikash Garodia
2025-01-10 14:28       ` Johan Hovold
2025-01-10 17:30         ` Dikshita Agarwal
2025-01-10 18:01           ` Dmitry Baryshkov
2025-01-11 10:45             ` Hans Verkuil
2025-01-13  8:51               ` Dmitry Baryshkov
2025-01-15 15:15               ` Bryan O'Donoghue
2025-02-03  8:39             ` Johan Hovold
2025-02-03 15:37               ` Dmitry Baryshkov
2025-02-04  9:52                 ` Johan Hovold
2025-02-04 15:35                   ` Dmitry Baryshkov
2025-02-04 16:22                     ` Johan Hovold
2025-01-10  0:12     ` Dmitry Baryshkov
2025-01-15 22:49       ` Bryan O'Donoghue
2025-01-15 22:51         ` Bryan O'Donoghue
2025-01-16  1:23         ` Dmitry Baryshkov
2024-12-12 11:51 ` [PATCH v9 28/28] media: MAINTAINERS: add Qualcomm iris video accelerator driver Dikshita Agarwal
2024-12-14 11:04 ` [PATCH v9 00/28] Qualcomm iris video decoder driver Krzysztof Kozlowski
2024-12-16 14:48 ` Neil Armstrong
2025-01-06 12:36 ` Joel Stanley
2025-01-06 12:46   ` Joel Stanley
2025-01-08  9:54     ` Dikshita Agarwal
2025-01-08  9:52   ` Dikshita Agarwal
2025-01-08 11:00     ` Dmitry Baryshkov
2025-01-09 14:58 ` Johan Hovold
2025-01-22 15:34   ` Stefan Schmidt
2025-02-03  8:43     ` Johan Hovold
2025-02-03  9:27       ` Vikash Garodia [this message]
2025-01-15 22:57 ` Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4dab19d0-22eb-2395-56fd-758c3c0d8bc7@quicinc.com \
    --to=quic_vgarodia@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=hverkuil@xs4all.nl \
    --cc=johan@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=lujianhua000@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=nicolas@ndufresne.ca \
    --cc=p.zabel@pengutronix.de \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_dikshita@quicinc.com \
    --cc=quic_vnagar@quicinc.com \
    --cc=robh@kernel.org \
    --cc=sebastian.fricke@collabora.com \
    --cc=stefan.schmidt@linaro.org \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®