From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Leo Yan <leo.yan@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] coresight: Update comments for removing cs_etm_find_snapshot()
Date: Mon, 6 Sep 2021 10:51:02 +0100 [thread overview]
Message-ID: <4db83b64-445d-2a04-a130-fd95f9157702@arm.com> (raw)
In-Reply-To: <20210905131237.1035322-3-leo.yan@linaro.org>
Hi Leo
On 05/09/2021 14:12, Leo Yan wrote:
> Commit 2f01c200d440 ("perf cs-etm: Remove callback cs_etm_find_snapshot()")
> has removed the function cs_etm_find_snapshot() from the perf tool in the
> user space, now CoreSight trace directly uses the perf common function
> __auxtrace_mmap__read() to calcualte the head and size for AUX trace data
> in snapshot mode.
>
> Updates the comments in drivers to reflect the changes.
As such I would avoid referencing "userspace" function names in the
kernel driver. Please could we remove it or make it generic ?
Also, remember, perf is not the only userspace tool driving the kernel
perf.
Cheers
Suzuki
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
> drivers/hwtracing/coresight/coresight-etb10.c | 2 +-
> drivers/hwtracing/coresight/coresight-tmc-etf.c | 2 +-
> drivers/hwtracing/coresight/coresight-tmc-etr.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c
> index f775cbee12b8..1cdb627d6c38 100644
> --- a/drivers/hwtracing/coresight/coresight-etb10.c
> +++ b/drivers/hwtracing/coresight/coresight-etb10.c
> @@ -557,7 +557,7 @@ static unsigned long etb_update_buffer(struct coresight_device *csdev,
>
> /*
> * In snapshot mode we simply increment the head by the number of byte
> - * that were written. User space function cs_etm_find_snapshot() will
> + * that were written. User space function __auxtrace_mmap__read() will
> * figure out how many bytes to get from the AUX buffer based on the
> * position of the head.
> */
> diff --git a/drivers/hwtracing/coresight/coresight-tmc-etf.c b/drivers/hwtracing/coresight/coresight-tmc-etf.c
> index cd0fb7bfba68..a895931a2766 100644
> --- a/drivers/hwtracing/coresight/coresight-tmc-etf.c
> +++ b/drivers/hwtracing/coresight/coresight-tmc-etf.c
> @@ -546,7 +546,7 @@ static unsigned long tmc_update_etf_buffer(struct coresight_device *csdev,
>
> /*
> * In snapshot mode we simply increment the head by the number of byte
> - * that were written. User space function cs_etm_find_snapshot() will
> + * that were written. User space function __auxtrace_mmap__read() will
> * figure out how many bytes to get from the AUX buffer based on the
> * position of the head.
> */
> diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c
> index d23c7690f29a..941abb70b827 100644
> --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c
> +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c
> @@ -1573,7 +1573,7 @@ tmc_update_etr_buffer(struct coresight_device *csdev,
>
> /*
> * In snapshot mode we simply increment the head by the number of byte
> - * that were written. User space function cs_etm_find_snapshot() will
> + * that were written. User space function __auxtrace_mmap__read() will
> * figure out how many bytes to get from the AUX buffer based on the
> * position of the head.
> */
>
next prev parent reply other threads:[~2021-09-06 9:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-05 13:12 [PATCH v3 0/2] coresight: Fix for snapshot mode Leo Yan
2021-09-05 13:12 ` [PATCH v3 1/2] coresight: tmc-etr: Use perf_output_handle::head for AUX ring buffer Leo Yan
2021-09-05 13:12 ` [PATCH v3 2/2] coresight: Update comments for removing cs_etm_find_snapshot() Leo Yan
2021-09-06 9:51 ` Suzuki K Poulose [this message]
2021-09-06 10:28 ` Leo Yan
2021-09-06 10:31 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4db83b64-445d-2a04-a130-fd95f9157702@arm.com \
--to=suzuki.poulose@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@arm.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®