From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] coresight: Update comments for removing cs_etm_find_snapshot()
Date: Mon, 6 Sep 2021 11:31:24 +0100 [thread overview]
Message-ID: <b5e78a4e-e92b-cbf8-be8c-611b2f1be81b@arm.com> (raw)
In-Reply-To: <20210906102849.GA1164772@leoy-ThinkPad-X240s>
On 06/09/2021 11:28, Leo Yan wrote:
> Hi Suzuki,
>
> On Mon, Sep 06, 2021 at 10:51:02AM +0100, Suzuki Kuruppassery Poulose wrote:
>> Hi Leo
>>
>>
>> On 05/09/2021 14:12, Leo Yan wrote:
>>> Commit 2f01c200d440 ("perf cs-etm: Remove callback cs_etm_find_snapshot()")
>>> has removed the function cs_etm_find_snapshot() from the perf tool in the
>>> user space, now CoreSight trace directly uses the perf common function
>>> __auxtrace_mmap__read() to calcualte the head and size for AUX trace data
>>> in snapshot mode.
>>>
>>> Updates the comments in drivers to reflect the changes.
>>
>> As such I would avoid referencing "userspace" function names in the
>> kernel driver. Please could we remove it or make it generic ?
>
> Okay, I'd like to remove the specific function name from the comment so
> can make the comment generic as:
>
> "User space will figure out how many bytes to get from the AUX buffer
> based on the position of the head."
Yes please, that sounds perfect.
Cheers
Suzuki
prev parent reply other threads:[~2021-09-06 10:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-05 13:12 [PATCH v3 0/2] coresight: Fix for snapshot mode Leo Yan
2021-09-05 13:12 ` [PATCH v3 1/2] coresight: tmc-etr: Use perf_output_handle::head for AUX ring buffer Leo Yan
2021-09-05 13:12 ` [PATCH v3 2/2] coresight: Update comments for removing cs_etm_find_snapshot() Leo Yan
2021-09-06 9:51 ` Suzuki K Poulose
2021-09-06 10:28 ` Leo Yan
2021-09-06 10:31 ` Suzuki K Poulose [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5e78a4e-e92b-cbf8-be8c-611b2f1be81b@arm.com \
--to=suzuki.poulose@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@arm.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®