* [PATCH] drm/client: Fix drm client endless Kconfig loop
@ 2024-12-12 9:11 Jocelyn Falempe
2024-12-12 10:27 ` Jocelyn Falempe
0 siblings, 1 reply; 2+ messages in thread
From: Jocelyn Falempe @ 2024-12-12 9:11 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, John Ogness,
Javier Martinez Canillas, Guilherme G . Piccoli,
bluescreen_avenger, Caleb Connolly, Petr Mladek, Jani Nikula,
dri-devel, linux-kernel
Cc: Jocelyn Falempe, Dan Carpenter
if DRM_CLIENT_SELECTION is enabled, and none of the client is, the
"Default DRM Client" choice is empty, and this makes Kconfig goes
into an infinite loop of:
Default DRM Client
choice[1-0?]: 0
Default DRM Client
choice[1-0?]: 0
Default DRM Client
choice[1-0?]: 0
....
So only allow the choice if at least one of the client is selected.
Fixes: f7b42442c4ac ("drm/log: Introduce a new boot logger to draw the kmsg on the screen")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
Tested-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/gpu/drm/clients/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/clients/Kconfig b/drivers/gpu/drm/clients/Kconfig
index c18decc90200..82a7d4e584dd 100644
--- a/drivers/gpu/drm/clients/Kconfig
+++ b/drivers/gpu/drm/clients/Kconfig
@@ -87,6 +87,7 @@ config DRM_CLIENT_LOG
choice
prompt "Default DRM Client"
depends on DRM_CLIENT_SELECTION
+ depends on DRM_FBDEV_EMULATION || DRM_CLIENT_LOG
default DRM_CLIENT_DEFAULT_FBDEV
help
Selects the default drm client.
base-commit: 19851fa2ba9824bede16f55234f63d9423897c3d
--
2.47.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm/client: Fix drm client endless Kconfig loop
2024-12-12 9:11 [PATCH] drm/client: Fix drm client endless Kconfig loop Jocelyn Falempe
@ 2024-12-12 10:27 ` Jocelyn Falempe
0 siblings, 0 replies; 2+ messages in thread
From: Jocelyn Falempe @ 2024-12-12 10:27 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, John Ogness,
Javier Martinez Canillas, Guilherme G . Piccoli,
bluescreen_avenger, Caleb Connolly, Petr Mladek, Jani Nikula,
dri-devel, linux-kernel
Cc: Dan Carpenter
On 12/12/2024 10:11, Jocelyn Falempe wrote:
> if DRM_CLIENT_SELECTION is enabled, and none of the client is, the
> "Default DRM Client" choice is empty, and this makes Kconfig goes
> into an infinite loop of:
>
> Default DRM Client
> choice[1-0?]: 0
> Default DRM Client
> choice[1-0?]: 0
> Default DRM Client
> choice[1-0?]: 0
> ....
>
> So only allow the choice if at least one of the client is selected.
I've pushed it to drm-misc-next, endless Kconfig loop is not fun for CI.
Best regards,
--
Jocelyn
>
> Fixes: f7b42442c4ac ("drm/log: Introduce a new boot logger to draw the kmsg on the screen")
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
> Tested-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/gpu/drm/clients/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/clients/Kconfig b/drivers/gpu/drm/clients/Kconfig
> index c18decc90200..82a7d4e584dd 100644
> --- a/drivers/gpu/drm/clients/Kconfig
> +++ b/drivers/gpu/drm/clients/Kconfig
> @@ -87,6 +87,7 @@ config DRM_CLIENT_LOG
> choice
> prompt "Default DRM Client"
> depends on DRM_CLIENT_SELECTION
> + depends on DRM_FBDEV_EMULATION || DRM_CLIENT_LOG
> default DRM_CLIENT_DEFAULT_FBDEV
> help
> Selects the default drm client.
>
> base-commit: 19851fa2ba9824bede16f55234f63d9423897c3d
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-12 10:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-12 9:11 [PATCH] drm/client: Fix drm client endless Kconfig loop Jocelyn Falempe
2024-12-12 10:27 ` Jocelyn Falempe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®