From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Thomas Gleixner <tglx@linutronix.de>, Enrico Weigelt <info@metux.net>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Darren Hart <dvhart@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-gpio@vger.kernel.org, Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] gpio: amd-fch: Fix bogus SPDX identifier
Date: Wed, 20 Mar 2019 17:04:41 +0100 [thread overview]
Message-ID: <4dcdcd9c-e599-5b8a-b628-4b02b7a092a1@metux.net> (raw)
In-Reply-To: <alpine.DEB.2.21.1903191513170.2537@nanos.tec.linutronix.de>
On 19.03.19 15:28, Thomas Gleixner wrote:
> spdxcheck.py complains:
>
> include/linux/platform_data/gpio/gpio-amd-fch.h: 1:28 Invalid License ID: GPL+
>
> which is correct because GPL+ is not a valid identifier. Of course this
> could have been caught by checkpatch.pl _before_ submitting or merging the
> patch.
>
> WARNING: 'SPDX-License-Identifier: GPL+ */' is not supported in LICENSES/...
> #271: FILE: include/linux/platform_data/gpio/gpio-amd-fch.h:1:
> +/* SPDX-License-Identifier: GPL+ */
>
> Fix it under the assumption that the author meant GPL-2.0+, which makes
> sense as the corresponding C file is using that identifier.
Your assumption is correct.
Acked-By: Enrico Weigelt <info@metux.net>
I just wonder, why checkpatch.pl didn't bleat me.
Thanks for the fix.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
prev parent reply other threads:[~2019-03-20 16:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 14:28 Thomas Gleixner
2019-03-19 14:54 ` [PATCH V2] " Thomas Gleixner
2019-03-19 17:19 ` Bartosz Golaszewski
2019-03-20 16:04 ` Enrico Weigelt, metux IT consult [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4dcdcd9c-e599-5b8a-b628-4b02b7a092a1@metux.net \
--to=lkml@metux.net \
--cc=andy.shevchenko@gmail.com \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®