* [PATCH] gpio: amd-fch: Fix bogus SPDX identifier
@ 2019-03-19 14:28 Thomas Gleixner
2019-03-19 14:54 ` [PATCH V2] " Thomas Gleixner
2019-03-20 16:04 ` [PATCH] " Enrico Weigelt, metux IT consult
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Gleixner @ 2019-03-19 14:28 UTC (permalink / raw)
To: Enrico Weigelt
Cc: Linus Walleij, Andy Shevchenko, Darren Hart, LKML, linux-gpio, Greg KH
spdxcheck.py complains:
include/linux/platform_data/gpio/gpio-amd-fch.h: 1:28 Invalid License ID: GPL+
which is correct because GPL+ is not a valid identifier. Of course this
could have been caught by checkpatch.pl _before_ submitting or merging the
patch.
WARNING: 'SPDX-License-Identifier: GPL+ */' is not supported in LICENSES/...
#271: FILE: include/linux/platform_data/gpio/gpio-amd-fch.h:1:
+/* SPDX-License-Identifier: GPL+ */
Fix it under the assumption that the author meant GPL-2.0+, which makes
sense as the corresponding C file is using that identifier.
Fixes: e09d168f13f0 ("gpio: AMD G-Series PCH gpio driver")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
diff --git a/include/linux/platform_data/gpio/gpio-amd-fch.h b/include/linux/platform_data/gpio/gpio-amd-fch.h
index a867637e172d..7290ec40a71e 100644
--- a/include/linux/platform_data/gpio/gpio-amd-fch.h
+++ b/include/linux/platform_data/gpio/gpio-amd-fch.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL+ */
+/* SPDX-License-Identifier: GPL2.0+ */
/*
* AMD FCH gpio driver platform-data
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH V2] gpio: amd-fch: Fix bogus SPDX identifier
2019-03-19 14:28 [PATCH] gpio: amd-fch: Fix bogus SPDX identifier Thomas Gleixner
@ 2019-03-19 14:54 ` Thomas Gleixner
2019-03-19 17:19 ` Bartosz Golaszewski
2019-03-20 16:04 ` [PATCH] " Enrico Weigelt, metux IT consult
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Gleixner @ 2019-03-19 14:54 UTC (permalink / raw)
To: Enrico Weigelt
Cc: Linus Walleij, Andy Shevchenko, Darren Hart, LKML, linux-gpio, Greg KH
spdxcheck.py complains:
include/linux/platform_data/gpio/gpio-amd-fch.h: 1:28 Invalid License ID: GPL+
which is correct because GPL+ is not a valid identifier. Of course this
could have been caught by checkpatch.pl _before_ submitting or merging the
patch.
WARNING: 'SPDX-License-Identifier: GPL+ */' is not supported in LICENSES/...
#271: FILE: include/linux/platform_data/gpio/gpio-amd-fch.h:1:
+/* SPDX-License-Identifier: GPL+ */
Fix it under the assumption that the author meant GPL-2.0+, which makes
sense as the corresponding C file is using that identifier.
Fixes: e09d168f13f0 ("gpio: AMD G-Series PCH gpio driver")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
Stupid me should refresh patches before sending them. Blush!
---
diff --git a/include/linux/platform_data/gpio/gpio-amd-fch.h b/include/linux/platform_data/gpio/gpio-amd-fch.h
index a867637e172d..7290ec40a71e 100644
--- a/include/linux/platform_data/gpio/gpio-amd-fch.h
+++ b/include/linux/platform_data/gpio/gpio-amd-fch.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL+ */
+/* SPDX-License-Identifier: GPL-2.0+ */
/*
* AMD FCH gpio driver platform-data
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH V2] gpio: amd-fch: Fix bogus SPDX identifier
2019-03-19 14:54 ` [PATCH V2] " Thomas Gleixner
@ 2019-03-19 17:19 ` Bartosz Golaszewski
0 siblings, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2019-03-19 17:19 UTC (permalink / raw)
To: Thomas Gleixner
Cc: Enrico Weigelt, Linus Walleij, Andy Shevchenko, Darren Hart,
LKML, open list:GPIO SUBSYSTEM, Greg KH
wt., 19 mar 2019 o 15:54 Thomas Gleixner <tglx@linutronix.de> napisał(a):
>
> spdxcheck.py complains:
>
> include/linux/platform_data/gpio/gpio-amd-fch.h: 1:28 Invalid License ID: GPL+
>
> which is correct because GPL+ is not a valid identifier. Of course this
> could have been caught by checkpatch.pl _before_ submitting or merging the
> patch.
>
> WARNING: 'SPDX-License-Identifier: GPL+ */' is not supported in LICENSES/...
> #271: FILE: include/linux/platform_data/gpio/gpio-amd-fch.h:1:
> +/* SPDX-License-Identifier: GPL+ */
>
> Fix it under the assumption that the author meant GPL-2.0+, which makes
> sense as the corresponding C file is using that identifier.
>
> Fixes: e09d168f13f0 ("gpio: AMD G-Series PCH gpio driver")
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> Stupid me should refresh patches before sending them. Blush!
> ---
> diff --git a/include/linux/platform_data/gpio/gpio-amd-fch.h b/include/linux/platform_data/gpio/gpio-amd-fch.h
> index a867637e172d..7290ec40a71e 100644
> --- a/include/linux/platform_data/gpio/gpio-amd-fch.h
> +++ b/include/linux/platform_data/gpio/gpio-amd-fch.h
> @@ -1,4 +1,4 @@
> -/* SPDX-License-Identifier: GPL+ */
> +/* SPDX-License-Identifier: GPL-2.0+ */
>
> /*
> * AMD FCH gpio driver platform-data
>
Patch applied.
Bart
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio: amd-fch: Fix bogus SPDX identifier
2019-03-19 14:28 [PATCH] gpio: amd-fch: Fix bogus SPDX identifier Thomas Gleixner
2019-03-19 14:54 ` [PATCH V2] " Thomas Gleixner
@ 2019-03-20 16:04 ` Enrico Weigelt, metux IT consult
1 sibling, 0 replies; 4+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-03-20 16:04 UTC (permalink / raw)
To: Thomas Gleixner, Enrico Weigelt
Cc: Linus Walleij, Andy Shevchenko, Darren Hart, LKML, linux-gpio, Greg KH
On 19.03.19 15:28, Thomas Gleixner wrote:
> spdxcheck.py complains:
>
> include/linux/platform_data/gpio/gpio-amd-fch.h: 1:28 Invalid License ID: GPL+
>
> which is correct because GPL+ is not a valid identifier. Of course this
> could have been caught by checkpatch.pl _before_ submitting or merging the
> patch.
>
> WARNING: 'SPDX-License-Identifier: GPL+ */' is not supported in LICENSES/...
> #271: FILE: include/linux/platform_data/gpio/gpio-amd-fch.h:1:
> +/* SPDX-License-Identifier: GPL+ */
>
> Fix it under the assumption that the author meant GPL-2.0+, which makes
> sense as the corresponding C file is using that identifier.
Your assumption is correct.
Acked-By: Enrico Weigelt <info@metux.net>
I just wonder, why checkpatch.pl didn't bleat me.
Thanks for the fix.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-20 16:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 14:28 [PATCH] gpio: amd-fch: Fix bogus SPDX identifier Thomas Gleixner
2019-03-19 14:54 ` [PATCH V2] " Thomas Gleixner
2019-03-19 17:19 ` Bartosz Golaszewski
2019-03-20 16:04 ` [PATCH] " Enrico Weigelt, metux IT consult
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®