From: Paolo Bonzini <pbonzini@redhat.com>
To: Xiaoyao Li <xiaoyao.li@intel.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: Ackerley Tng <ackerleytng@google.com>,
Fuad Tabba <tabba@google.com>,
Binbin Wu <binbin.wu@linux.intel.com>,
Shivank Garg <shivankg@amd.com>, Yan Zhao <yan.y.zhao@intel.com>,
Sean Christopherson <seanjc@google.com>
Subject: Re: [PATCH 3/3] KVM: always make in-place conversion a compile-time constant when possible
Date: Wed, 21 Oct 2026 09:12:34 +0200 [thread overview]
Message-ID: <4ddec6f4-1db9-4efc-9e43-b26104505174@redhat.com> (raw)
In-Reply-To: <4217cec4-2988-41a9-b6de-cce0708ec830@intel.com>
On 10/21/26 09:07, Xiaoyao Li wrote:
> On 10/20/2026 9:14 PM, Paolo Bonzini wrote:
>> Remove the unnecessary static call indirection and make
>> gmem_in_place_conversion a constant if CONFIG_KVM_PRIVATE_MEMATTR_VM
>> is false.
>>
>> Require that CONFIG_KVM_PRIVATE_MEMATTR_VM is y only if
>> kvm_arch_has_private_mem is also defined.
>
> This reads like the patch is going to make such a requirement. However, it doesn't.
It does in the sense that, if you set CONFIG_KVM_PRIVATE_MEMATTR_VM=y
without defining kvm_arch_has_private_mem, you'll get a useless
gmem_in_place_conversion module parameter.
Also, if CONFIG_KVM_GUEST_MEMFD=n, you'll get an undefined symbol
kvm_gmem_is_private_gfn(). Previously, you wouldn't get the undefined
symbol if kvm_arch_has_private_mem was not defined.
Paolo
next prev parent reply other threads:[~2026-10-21 7:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 13:14 [PATCH 0/3] KVM: Kconfig fixes for the VM-wide private memory attribute Paolo Bonzini
2026-10-20 13:14 ` [PATCH 1/3] KVM: split CONFIG_KVM_PRIVATE_MEMATTR_VM out of KVM_VM_MEMORY_ATTRIBUTES Paolo Bonzini
2026-10-21 7:01 ` Xiaoyao Li
2026-10-20 13:14 ` [PATCH 2/3] KVM: x86: leave the legacy private attribute in for TDX and SEV Paolo Bonzini
2026-10-21 7:05 ` Xiaoyao Li
2026-10-20 13:14 ` [PATCH 3/3] KVM: always make in-place conversion a compile-time constant when possible Paolo Bonzini
2026-10-21 7:07 ` Xiaoyao Li
2026-10-21 7:12 ` Paolo Bonzini [this message]
2026-10-21 4:57 ` [PATCH 0/3] KVM: Kconfig fixes for the VM-wide private memory attribute Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ddec6f4-1db9-4efc-9e43-b26104505174@redhat.com \
--to=pbonzini@redhat.com \
--cc=ackerleytng@google.com \
--cc=binbin.wu@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanjc@google.com \
--cc=shivankg@amd.com \
--cc=tabba@google.com \
--cc=xiaoyao.li@intel.com \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®