mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xiaoyao Li <xiaoyao.li@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: Ackerley Tng <ackerleytng@google.com>,
	Fuad Tabba <tabba@google.com>,
	Binbin Wu <binbin.wu@linux.intel.com>,
	Shivank Garg <shivankg@amd.com>, Yan Zhao <yan.y.zhao@intel.com>,
	Sean Christopherson <seanjc@google.com>
Subject: Re: [PATCH 2/3] KVM: x86: leave the legacy private attribute in for TDX and SEV
Date: Wed, 21 Oct 2026 15:05:32 +0800	[thread overview]
Message-ID: <de8b810c-1ee2-4087-927a-06f3975ba670@intel.com> (raw)
In-Reply-To: <20261020131447.122096-3-pbonzini@redhat.com>

On 10/20/2026 9:14 PM, Paolo Bonzini wrote:
> As of today, and presumably as of Linux 7.4's release date, there
> is hardly any VMM that supports guest_memfd attributes.  Support the
> legacy VM attribute for private memory if SEV or TDX are requested;
> default it to disabled if only the software-protected VM is requested,
> since it is only used by guest_memfd selftests.
> 
> While in-place conversion is the best option, it is way too
> early to enable it by default.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com>

> ---
>  arch/x86/kvm/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> index 01a683a9042a..4f7d75ec8c40 100644
> --- a/arch/x86/kvm/Kconfig
> +++ b/arch/x86/kvm/Kconfig
> @@ -80,6 +80,7 @@ config KVM_PRIVATE_MEMATTR_VM
>  	bool "Enable per-VM PRIVATE vs. SHARED attributes (for CoCo VMs)"
>  	depends on KVM_SW_PROTECTED_VM || KVM_INTEL_TDX || KVM_AMD_SEV
>  	select KVM_VM_MEMORY_ATTRIBUTES
> +	default KVM_INTEL_TDX || KVM_AMD_SEV
>  	help
>  	  Enable support for tracking PRIVATE vs. SHARED memory using per-VM
>  	  memory attributes.  Using per-VM attributes is deprecated in favor of
> @@ -87,7 +88,7 @@ config KVM_PRIVATE_MEMATTR_VM
>  	  CoCo VMs using a VMM that doesn't support guest_memfd memory
>  	  attributes.
>  
> -	  If unsure, say N.
> +	  If unsure, say "Y".

It looks the no-quote version is more popular.

          If unsure, say Y.

>  
>  config KVM_SW_PROTECTED_VM
>  	bool "Enable support for KVM software-protected VMs"


  reply	other threads:[~2026-10-21  7:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20 13:14 [PATCH 0/3] KVM: Kconfig fixes for the VM-wide private memory attribute Paolo Bonzini
2026-10-20 13:14 ` [PATCH 1/3] KVM: split CONFIG_KVM_PRIVATE_MEMATTR_VM out of KVM_VM_MEMORY_ATTRIBUTES Paolo Bonzini
2026-10-21  7:01   ` Xiaoyao Li
2026-10-20 13:14 ` [PATCH 2/3] KVM: x86: leave the legacy private attribute in for TDX and SEV Paolo Bonzini
2026-10-21  7:05   ` Xiaoyao Li [this message]
2026-10-20 13:14 ` [PATCH 3/3] KVM: always make in-place conversion a compile-time constant when possible Paolo Bonzini
2026-10-21  7:07   ` Xiaoyao Li
2026-10-21  7:12     ` Paolo Bonzini
2026-10-21  4:57 ` [PATCH 0/3] KVM: Kconfig fixes for the VM-wide private memory attribute Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de8b810c-1ee2-4087-927a-06f3975ba670@intel.com \
    --to=xiaoyao.li@intel.com \
    --cc=ackerleytng@google.com \
    --cc=binbin.wu@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=shivankg@amd.com \
    --cc=tabba@google.com \
    --cc=yan.y.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®