From: "Arnd Bergmann" <arnd@arndb.de>
To: "Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
"Hans de Goede" <hdegoede@redhat.com>,
"Tomas Winkler" <tomas.winkler@intel.com>,
"Wentong Wu" <wentong.wu@intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2 2/3] mei: vsc: Don't use sleeping condition in wait_event_timeout()
Date: Tue, 05 Mar 2024 18:17:46 +0100 [thread overview]
Message-ID: <4de9e676-74e7-4bd0-b821-4e3270487dbb@app.fastmail.com> (raw)
In-Reply-To: <ZedSJcBGj89-XQWY@smile.fi.intel.com>
On Tue, Mar 5, 2024, at 18:11, Andy Shevchenko wrote:
> On Mon, Feb 19, 2024 at 09:58:06PM +0200, Sakari Ailus wrote:
>> vsc_tp_wakeup_request() called wait_event_timeout() with
>> gpiod_get_value_cansleep() which may sleep, and does so as the
>> implementation is that of gpio-ljca.
>>
>> Move the GPIO state check outside the call.
>
> ...
>
>> +#define VSC_TP_WAIT_FW_POLL_TIMEOUT (2 * HZ)
>> +#define VSC_TP_WAIT_FW_POLL_DELAY_US (20 * USEC_PER_MSEC)
>
> ...
>
>> ret = wait_event_timeout(tp->xfer_wait,
>> - atomic_read(&tp->assert_cnt) &&
>> - gpiod_get_value_cansleep(tp->wakeuphost),
>> - VSC_TP_WAIT_FW_ASSERTED_TIMEOUT);
>> + atomic_read(&tp->assert_cnt),
>> + VSC_TP_WAIT_FW_POLL_TIMEOUT);
>
> First of all, there is an API for such cases (wait_woken_up() IIRC).
I think wait_for_completion_timeout() would be the obvious
replacement if the wait_event is no longer waiting for the
gpio but only for the irq handler to complete.
Arnd
next prev parent reply other threads:[~2024-03-05 17:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 19:58 [PATCH v2 0/3] MEI VSC fixes and cleanups Sakari Ailus
2024-02-19 19:58 ` [PATCH v2 1/3] mei: vsc: Call wake_up() in the threaded IRQ handler Sakari Ailus
2024-02-22 3:26 ` Wu, Wentong
2024-02-22 11:46 ` Sakari Ailus
2024-03-04 10:58 ` Arnd Bergmann
2024-02-28 8:19 ` Wu, Wentong
2024-03-04 10:42 ` Sakari Ailus
2024-02-19 19:58 ` [PATCH v2 2/3] mei: vsc: Don't use sleeping condition in wait_event_timeout() Sakari Ailus
2024-02-22 4:30 ` Wu, Wentong
2024-03-05 17:11 ` Andy Shevchenko
2024-03-05 17:17 ` Arnd Bergmann [this message]
2024-02-19 19:58 ` [PATCH v2 3/3] mei: vsc: Assign pinfo fields in variable declaration Sakari Ailus
2024-02-22 4:32 ` Wu, Wentong
2024-03-05 17:13 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4de9e676-74e7-4bd0-b821-4e3270487dbb@app.fastmail.com \
--to=arnd@arndb.de \
--cc=andriy.shevchenko@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomas.winkler@intel.com \
--cc=wentong.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®