Re: [PATCH v1 5/5] ASoC: qcom: sc8280xp: Add shikra-iqs-lt9611uxd-evk compatible support

[Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>]

On 10/22/2026 3:13 PM, Karthik S wrote:
> Add machine driver support for the Shikra IQS EVK variant that uses the
> LT9611UXD HDMI bridge as an I2S audio codec instead of the MAX98091.
> The new compatible reuses the generic sc8280xp DAPM widgets and configures
> the codec DAI format for I2S with bit/frame clock driven by the codec.
> 
> Signed-off-by: Karthik S <karthik.s@oss.qualcomm.com>
> ---
>   sound/soc/qcom/sc8280xp.c | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c
> index 9860a68e2add..66064c31136b 100644
> --- a/sound/soc/qcom/sc8280xp.c
> +++ b/sound/soc/qcom/sc8280xp.c
> @@ -541,6 +541,15 @@ static const struct qcom_snd_soc_common shikra_iqs_priv_data = {
>   	.mi2s_bclk_enable = true,
>   };
>   
> +static const struct qcom_snd_soc_common shikra_iqs_lt9611uxd_priv_data = {
> +	.driver_name = "shikra",
> +	.dapm_widgets = sc8280xp_dapm_widgets,
> +	.num_dapm_widgets = ARRAY_SIZE(sc8280xp_dapm_widgets),
> +	.codec_dai_fmt = SND_SOC_DAIFMT_BC_FC |
> +			 SND_SOC_DAIFMT_NB_NF |
> +			 SND_SOC_DAIFMT_I2S,
> +};

Since the codec is configured as SND_SOC_DAIFMT_BC_FC, shouldn't we also 
set .mi2s_bclk_enable = true here?

> +
>   static const struct qcom_snd_soc_common sm8450_priv_data = {
>   	.driver_name = "sm8450",
>   	.dapm_widgets = sc8280xp_dapm_widgets,
> @@ -608,6 +617,8 @@ static const struct of_device_id snd_sc8280xp_dt_match[] = {
>   	{ .compatible = "qcom,qcs9100-sndcard", .data = &qcs9100_priv_data },
>   	{ .compatible = "qcom,sc8280xp-sndcard", .data = &sc8280xp_priv_data },
>   	{ .compatible = "qcom,shikra-iqs-sndcard", .data = &shikra_iqs_priv_data },
> +	{ .compatible = "qcom,shikra-iqs-lt9611uxd-sndcard",
> +	  .data = &shikra_iqs_lt9611uxd_priv_data },
>   	{ .compatible = "qcom,sm8450-sndcard", .data = &sm8450_priv_data },

Nit: please keep the compatible list sorted alphabetically.

Thanks
Ajay Kumar Nandam

>   	{ .compatible = "qcom,sm8475-sndcard", .data = &sm8475_priv_data },
>   	{ .compatible = "qcom,sm8550-sndcard", .data = &sm8550_priv_data },