From: Joe Perches <joe@perches.com>
To: Ani Sinha <ani@anisinha.ca>, Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
anirban.sinha@nokia.com, mikelley@microsoft.com,
Andy Whitcroft <apw@canonical.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>
Subject: Re: [PATCH v3] checkpatch: add a rule to check general block comment style
Date: Mon, 19 Jul 2021 00:52:17 -0700 [thread overview]
Message-ID: <4e42f2580d8b473ac7e25642b039adf73b5efe06.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2107191221570.12107@anisinha-lenovo>
On Mon, 2021-07-19 at 12:25 +0530, Ani Sinha wrote:
> I do not see why we cannot add this rule to checkpatch. If the
> reviewer likes the other style of commenting they can always ask for a
> correction. Having checkpatch agree with Linus' preferred style of
> commenting and the preferred documeted style of commenting (which seems to
> be the same) does make everything uniform and agreeable.
Too many novice developers take checkpatch output as dicta.
It's not.
It's just produces suggestions that should _always_ be taken
not very seriously. Those suggestions should perhaps be
considered, but good taste should always override a brainless
script.
_Very_ few senior developers really care that much about any
particular comment style.
These are the same senior developers that would be burdened
with unnecessary patches to review from those novice developers
that believe checkpatch should always be followed.
Do not unnecessarily burden senior developers.
They are generally have other priorities.
next prev parent reply other threads:[~2021-07-19 7:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 6:34 Ani Sinha
2021-07-16 16:15 ` Ani Sinha
2021-07-18 7:30 ` Lukas Bulwahn
2021-07-18 13:38 ` Ani Sinha
2021-07-18 14:22 ` Dwaipayan Ray
2021-07-18 15:04 ` Ani Sinha
2021-07-19 0:18 ` Joe Perches
2021-07-19 5:28 ` Ani Sinha
2021-07-19 5:58 ` Lukas Bulwahn
2021-07-19 6:55 ` Ani Sinha
2021-07-19 7:52 ` Joe Perches [this message]
2021-07-19 8:08 ` Ani Sinha
2021-07-19 8:39 ` Lukas Bulwahn
2021-07-19 9:52 ` Ani Sinha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e42f2580d8b473ac7e25642b039adf73b5efe06.camel@perches.com \
--to=joe@perches.com \
--cc=ani@anisinha.ca \
--cc=anirban.sinha@nokia.com \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=mikelley@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®