* Re: next/master bisection: boot on beaglebone-black
[not found] <5dd6d7d2.1c69fb81.48b6f.33f2@mx.google.com>
@ 2019-11-21 20:52 ` Florian Fainelli
0 siblings, 0 replies; only message in thread
From: Florian Fainelli @ 2019-11-21 20:52 UTC (permalink / raw)
To: kernelci.org bot, David S. Miller, tomeu.vizoso,
guillaume.tucker, Jouni Hogander, broonie, khilman, mgalka,
enric.balletbo
Cc: Eric Dumazet, linux-kernel, Jiri Pirko, Andy Shevchenko, netdev,
Ido Schimmel, Wang Hai, YueHaibing
On 11/21/19 10:30 AM, kernelci.org bot wrote:
> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
> * This automated bisection report was sent to you on the basis *
> * that you may be involved with the breaking commit it has *
> * found. No manual investigation has been done to verify it, *
> * and the root cause of the problem may be somewhere else. *
> * *
> * If you do send a fix, please include this trailer: *
> * Reported-by: "kernelci.org bot" <bot@kernelci.org> *
> * *
> * Hope this helps! *
> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
>
> next/master bisection: boot on beaglebone-black
>
> Summary:
> Start: 9942eae47585 Add linux-next specific files for 20191121
> Details: https://kernelci.org/boot/id/5dd6696859b514303ecf550d
> Plain log: https://storage.kernelci.org//next/master/next-20191121/arm/multi_v7_defconfig/gcc-8/lab-baylibre/boot-am335x-boneblack.txt
> HTML log: https://storage.kernelci.org//next/master/next-20191121/arm/multi_v7_defconfig/gcc-8/lab-baylibre/boot-am335x-boneblack.html
> Result: b8eb718348b8 net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject
>
> Checks:
> revert: PASS
> verify: PASS
>
> Parameters:
> Tree: next
> URL: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> Branch: master
> Target: beaglebone-black
> CPU arch: arm
> Lab: lab-baylibre
> Compiler: gcc-8
> Config: multi_v7_defconfig
> Test suite: boot
>
> Breaking commit found:
>
> -------------------------------------------------------------------------------
> commit b8eb718348b8fb30b5a7d0a8fce26fb3f4ac741b
> Author: Jouni Hogander <jouni.hogander@unikie.com>
> Date: Wed Nov 20 09:08:16 2019 +0200
>
> net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject
>
> kobject_init_and_add takes reference even when it fails. This has
> to be given up by the caller in error handling. Otherwise memory
> allocated by kobject_init_and_add is never freed. Originally found
> by Syzkaller:
>
> BUG: memory leak
> unreferenced object 0xffff8880679f8b08 (size 8):
> comm "netdev_register", pid 269, jiffies 4294693094 (age 12.132s)
> hex dump (first 8 bytes):
> 72 78 2d 30 00 36 20 d4 rx-0.6 .
> backtrace:
> [<000000008c93818e>] __kmalloc_track_caller+0x16e/0x290
> [<000000001f2e4e49>] kvasprintf+0xb1/0x140
> [<000000007f313394>] kvasprintf_const+0x56/0x160
> [<00000000aeca11c8>] kobject_set_name_vargs+0x5b/0x140
> [<0000000073a0367c>] kobject_init_and_add+0xd8/0x170
> [<0000000088838e4b>] net_rx_queue_update_kobjects+0x152/0x560
> [<000000006be5f104>] netdev_register_kobject+0x210/0x380
> [<00000000e31dab9d>] register_netdevice+0xa1b/0xf00
> [<00000000f68b2465>] __tun_chr_ioctl+0x20d5/0x3dd0
> [<000000004c50599f>] tun_chr_ioctl+0x2f/0x40
> [<00000000bbd4c317>] do_vfs_ioctl+0x1c7/0x1510
> [<00000000d4c59e8f>] ksys_ioctl+0x99/0xb0
> [<00000000946aea81>] __x64_sys_ioctl+0x78/0xb0
> [<0000000038d946e5>] do_syscall_64+0x16f/0x580
> [<00000000e0aa5d8f>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
> [<00000000285b3d1a>] 0xffffffffffffffff
>
> Cc: David Miller <davem@davemloft.net>
> Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> Signed-off-by: Jouni Hogander <jouni.hogander@unikie.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
This should be fixed by Eric's patch here:
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=48a322b6f9965b2f1e4ce81af972f0e287b07ed0
--
Florian
^ permalink raw reply [flat|nested] only message in thread