* [PATCH] Check if start address is in vma region in NOMMU function get_user_pages().
@ 2006-08-31 8:09 Sonic Zhang
0 siblings, 0 replies; only message in thread
From: Sonic Zhang @ 2006-08-31 8:09 UTC (permalink / raw)
To: linux-kernel
Hi,
In NOMMU arch, if run "cat /proc/self/mem", data from physical address
0 are read. This behavior is different from MMU arch. In IA32,
message "cat: /proc/self/mem: Input/output error" is reported.
This issue is rootcaused by not validate the start address in NOMMU
function get_user_pages(). Following patch solves this issue.
Thanks
Sonic Zhang
Signed-off-by: Sonic Zhang <sonic.adi@gmail.com>
--- linux-2.6.x/mm/nommu.c 2006-08-31 15:53:09.269952304 +0800
+++ linux-2.6.x/mm/nommu.c 2006-08-31 15:49:58.634933232 +0800
@@ -138,16 +138,20 @@
struct page **pages, struct vm_area_struct **vmas)
{
int i;
- static struct vm_area_struct dummy_vma;
+ struct vm_area_struct *vma;
for (i = 0; i < len; i++) {
+ vma = find_vma(mm, start);
+ if(!vma)
+ return i ? : -EFAULT;
+
if (pages) {
pages[i] = virt_to_page(start);
if (pages[i])
page_cache_get(pages[i]);
}
if (vmas)
- vmas[i] = &dummy_vma;
+ vmas[i] = vma;
start += PAGE_SIZE;
}
return(i);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-08-31 8:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-08-31 8:09 [PATCH] Check if start address is in vma region in NOMMU function get_user_pages() Sonic Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®