* [PATCH] regulator: bd96801: Delete unnecessary check in probe()
@ 2024-07-12 14:05 Dan Carpenter
2024-07-12 16:08 ` Markus Elfring
2024-07-29 15:39 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2024-07-12 14:05 UTC (permalink / raw)
To: Matti Vaittinen; +Cc: Liam Girdwood, Mark Brown, linux-kernel, kernel-janitors
The "idesc" pointer points to the middle of rdesc[] array so it can't be
NULL. Also rdesc isn't NULL. Delete the check.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/regulator/bd96801-regulator.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/regulator/bd96801-regulator.c b/drivers/regulator/bd96801-regulator.c
index 46ca81f18703..ec5b1a6b19e8 100644
--- a/drivers/regulator/bd96801-regulator.c
+++ b/drivers/regulator/bd96801-regulator.c
@@ -853,8 +853,6 @@ static int bd96801_probe(struct platform_device *pdev)
ldo_errs_arr[temp_notif_ldos] = rdesc[i].ldo_errs;
temp_notif_ldos++;
}
- if (!idesc)
- continue;
/* Register INTB handlers for configured protections */
for (j = 0; j < idesc->num_irqs; j++) {
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] regulator: bd96801: Delete unnecessary check in probe()
2024-07-12 14:05 [PATCH] regulator: bd96801: Delete unnecessary check in probe() Dan Carpenter
@ 2024-07-12 16:08 ` Markus Elfring
2024-07-29 15:39 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2024-07-12 16:08 UTC (permalink / raw)
To: Dan Carpenter, kernel-janitors, Matti Vaittinen
Cc: LKML, Mark Brown, Liam Girdwood
> … Delete the check.
Would you like to refer to the function name “bd96801_probe” in the summary phrase?
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: bd96801: Delete unnecessary check in probe()
2024-07-12 14:05 [PATCH] regulator: bd96801: Delete unnecessary check in probe() Dan Carpenter
2024-07-12 16:08 ` Markus Elfring
@ 2024-07-29 15:39 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2024-07-29 15:39 UTC (permalink / raw)
To: Matti Vaittinen, Dan Carpenter
Cc: Liam Girdwood, linux-kernel, kernel-janitors
On Fri, 12 Jul 2024 09:05:39 -0500, Dan Carpenter wrote:
> The "idesc" pointer points to the middle of rdesc[] array so it can't be
> NULL. Also rdesc isn't NULL. Delete the check.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[1/1] regulator: bd96801: Delete unnecessary check in probe()
commit: f0aaae1a5827c916f2d66e4392726c0c43d0479c
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-29 15:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-12 14:05 [PATCH] regulator: bd96801: Delete unnecessary check in probe() Dan Carpenter
2024-07-12 16:08 ` Markus Elfring
2024-07-29 15:39 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®