* [PATCH -next] drm/nouveau/kms/nvd9-: Fix file release memory leak
@ 2020-07-21 15:17 Wei Yongjun
2020-07-21 15:50 ` Lyude Paul
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2020-07-21 15:17 UTC (permalink / raw)
To: Ben Skeggs, David Airlie, Daniel Vetter, Lyude Paul, Dave Airlie
Cc: Wei Yongjun, dri-devel, nouveau, linux-kernel, kernel-janitors,
Hulk Robot
When using single_open() for opening, single_release() should be
used instead of seq_release(), otherwise there is a memory leak.
Fixes: 12885ecbfe62 ("drm/nouveau/kms/nvd9-: Add CRC support")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/gpu/drm/nouveau/dispnv50/crc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/nouveau/dispnv50/crc.c b/drivers/gpu/drm/nouveau/dispnv50/crc.c
index f17fb6d56757..4971a1042415 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/crc.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/crc.c
@@ -706,6 +706,7 @@ static const struct file_operations nv50_crc_flip_threshold_fops = {
.open = nv50_crc_debugfs_flip_threshold_open,
.read = seq_read,
.write = nv50_crc_debugfs_flip_threshold_set,
+ .release = single_release,
};
int nv50_head_crc_late_register(struct nv50_head *head)
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH -next] drm/nouveau/kms/nvd9-: Fix file release memory leak
2020-07-21 15:17 [PATCH -next] drm/nouveau/kms/nvd9-: Fix file release memory leak Wei Yongjun
@ 2020-07-21 15:50 ` Lyude Paul
0 siblings, 0 replies; 2+ messages in thread
From: Lyude Paul @ 2020-07-21 15:50 UTC (permalink / raw)
To: Wei Yongjun, Ben Skeggs, David Airlie, Daniel Vetter, Dave Airlie
Cc: dri-devel, nouveau, linux-kernel, kernel-janitors, Hulk Robot
Reviewed-by: Lyude Paul <lyude@redhat.com>
Thanks!
On Tue, 2020-07-21 at 15:17 +0000, Wei Yongjun wrote:
> When using single_open() for opening, single_release() should be
> used instead of seq_release(), otherwise there is a memory leak.
>
> Fixes: 12885ecbfe62 ("drm/nouveau/kms/nvd9-: Add CRC support")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/gpu/drm/nouveau/dispnv50/crc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/nouveau/dispnv50/crc.c
> b/drivers/gpu/drm/nouveau/dispnv50/crc.c
> index f17fb6d56757..4971a1042415 100644
> --- a/drivers/gpu/drm/nouveau/dispnv50/crc.c
> +++ b/drivers/gpu/drm/nouveau/dispnv50/crc.c
> @@ -706,6 +706,7 @@ static const struct file_operations
> nv50_crc_flip_threshold_fops = {
> .open = nv50_crc_debugfs_flip_threshold_open,
> .read = seq_read,
> .write = nv50_crc_debugfs_flip_threshold_set,
> + .release = single_release,
> };
>
> int nv50_head_crc_late_register(struct nv50_head *head)
>
>
>
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-21 15:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21 15:17 [PATCH -next] drm/nouveau/kms/nvd9-: Fix file release memory leak Wei Yongjun
2020-07-21 15:50 ` Lyude Paul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®