* [PATCH] tpm: st33zp24: remove redundant null check on chip
@ 2018-04-06 16:21 Colin King
2018-04-09 11:11 ` Jarkko Sakkinen
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-04-06 16:21 UTC (permalink / raw)
To: Peter Huewe, Jarkko Sakkinen, Jason Gunthorpe, Arnd Bergmann,
Greg Kroah-Hartman, linux-integrity
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently chip is being dereferenced by the call to dev_get_drvdata
before it is being null checked, however, chip can never be null, so
this check is misleading and redundant. Remove it.
Detected by CoverityScan, CID#1357806 ("Dereference before null check")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
V2: don't check for null, just remove redundant null check,
thanks to Jason Gunthorpe for spotting that.
---
drivers/char/tpm/st33zp24/st33zp24.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/char/tpm/st33zp24/st33zp24.c b/drivers/char/tpm/st33zp24/st33zp24.c
index f95b9c75175b..abd675bec88c 100644
--- a/drivers/char/tpm/st33zp24/st33zp24.c
+++ b/drivers/char/tpm/st33zp24/st33zp24.c
@@ -373,8 +373,6 @@ static int st33zp24_send(struct tpm_chip *chip, unsigned char *buf,
int ret;
u8 data;
- if (!chip)
- return -EBUSY;
if (len < TPM_HEADER_SIZE)
return -EBUSY;
--
2.15.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] tpm: st33zp24: remove redundant null check on chip
2018-04-06 16:21 [PATCH] tpm: st33zp24: remove redundant null check on chip Colin King
@ 2018-04-09 11:11 ` Jarkko Sakkinen
0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Sakkinen @ 2018-04-09 11:11 UTC (permalink / raw)
To: Colin King, Peter Huewe, Jason Gunthorpe, Arnd Bergmann,
Greg Kroah-Hartman, linux-integrity
Cc: kernel-janitors, linux-kernel
On Fri, 2018-04-06 at 17:21 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently chip is being dereferenced by the call to dev_get_drvdata
> before it is being null checked, however, chip can never be null, so
> this check is misleading and redundant. Remove it.
>
> Detected by CoverityScan, CID#1357806 ("Dereference before null check")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> ---
>
> V2: don't check for null, just remove redundant null check,
> thanks to Jason Gunthorpe for spotting that.
>
> ---
> drivers/char/tpm/st33zp24/st33zp24.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/char/tpm/st33zp24/st33zp24.c
> b/drivers/char/tpm/st33zp24/st33zp24.c
> index f95b9c75175b..abd675bec88c 100644
> --- a/drivers/char/tpm/st33zp24/st33zp24.c
> +++ b/drivers/char/tpm/st33zp24/st33zp24.c
> @@ -373,8 +373,6 @@ static int st33zp24_send(struct tpm_chip *chip, unsigned
> char *buf,
> int ret;
> u8 data;
>
> - if (!chip)
> - return -EBUSY;
> if (len < TPM_HEADER_SIZE)
> return -EBUSY;
>
Reviewed-by: Jarkko Sakkinen <jarkkko.sakkinen@linux.intel.com>
/Jarkko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-09 11:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-06 16:21 [PATCH] tpm: st33zp24: remove redundant null check on chip Colin King
2018-04-09 11:11 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®