* Re: [PATCH v4 1/4] dt-bindings: PCI: qcom-ep: Add support for SA8775P SoC [not found] ` <45b8f4e1-b915-42f2-aa03-03cc9d1be9f7@linaro.org> @ 2023-10-30 10:19 ` Mrinmay Sarkar 2023-10-30 10:50 ` Krzysztof Kozlowski 0 siblings, 1 reply; 3+ messages in thread From: Mrinmay Sarkar @ 2023-10-30 10:19 UTC (permalink / raw) To: Krzysztof Kozlowski, agross, andersson, krzysztof.kozlowski+dt, conor+dt, konrad.dybcio, mani Cc: quic_shazhuss, quic_nitegupt, quic_ramkri, quic_nayiluri, dmitry.baryshkov, robh, quic_krichai, quic_vbadigan, quic_parass, quic_schintav, Bjorn Helgaas, Lorenzo Pieralisi, Krzysztof Wilczyński, Kishon Vijay Abraham I, linux-pci, linux-arm-msm, devicetree, linux-kernel, mhi On 10/27/2023 7:20 PM, Krzysztof Kozlowski wrote: > On 27/10/2023 15:33, Mrinmay Sarkar wrote: >> Add devicetree bindings support for SA8775P SoC. It has DMA register >> space and dma interrupt to support HDMA. >> >> Signed-off-by: Mrinmay Sarkar <quic_msarkar@quicinc.com> > Unfortunately I do not see any of my comment addressed. :( > > This is a friendly reminder during the review process. > > It seems my or other reviewer's previous comments were not fully > addressed. Maybe the feedback got lost between the quotes, maybe you > just forgot to apply it. Please go back to the previous discussion and > either implement all requested changes or keep discussing them. > > Thank you. > > Best regards, > Krzysztof Thanks Krzysztof for your review and patience. Sorry I missed your previous comment. If I understand correctly by constraining IO space/interrupt, you mean to add maxItems for reg and interrupt for other variants. If so, I verified adding maxItems for these properties and dtb check seems to be good. I will post the same in the next patch series. Thanks, Mrinmay > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4 1/4] dt-bindings: PCI: qcom-ep: Add support for SA8775P SoC 2023-10-30 10:19 ` [PATCH v4 1/4] dt-bindings: PCI: qcom-ep: Add support for SA8775P SoC Mrinmay Sarkar @ 2023-10-30 10:50 ` Krzysztof Kozlowski 2023-10-30 12:22 ` Mrinmay Sarkar 0 siblings, 1 reply; 3+ messages in thread From: Krzysztof Kozlowski @ 2023-10-30 10:50 UTC (permalink / raw) To: Mrinmay Sarkar, agross, andersson, krzysztof.kozlowski+dt, conor+dt, konrad.dybcio, mani Cc: quic_shazhuss, quic_nitegupt, quic_ramkri, quic_nayiluri, dmitry.baryshkov, robh, quic_krichai, quic_vbadigan, quic_parass, quic_schintav, Bjorn Helgaas, Lorenzo Pieralisi, Krzysztof Wilczyński, Kishon Vijay Abraham I, linux-pci, linux-arm-msm, devicetree, linux-kernel, mhi On 30/10/2023 11:19, Mrinmay Sarkar wrote: > > On 10/27/2023 7:20 PM, Krzysztof Kozlowski wrote: >> On 27/10/2023 15:33, Mrinmay Sarkar wrote: >>> Add devicetree bindings support for SA8775P SoC. It has DMA register >>> space and dma interrupt to support HDMA. >>> >>> Signed-off-by: Mrinmay Sarkar <quic_msarkar@quicinc.com> >> Unfortunately I do not see any of my comment addressed. :( >> >> This is a friendly reminder during the review process. >> >> It seems my or other reviewer's previous comments were not fully >> addressed. Maybe the feedback got lost between the quotes, maybe you >> just forgot to apply it. Please go back to the previous discussion and >> either implement all requested changes or keep discussing them. >> >> Thank you. >> >> Best regards, >> Krzysztof > Thanks Krzysztof for your review and patience. > Sorry I missed your previous comment. Multiple comments. Also from Mani and maybe from others? > > If I understand correctly by constraining IO space/interrupt, > you mean to add maxItems for reg and interrupt for other variants. > If so, I verified adding maxItems for these properties and dtb check > seems to be good. I will post the same in the next patch series. > > Thanks, > Mrinmay >> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4 1/4] dt-bindings: PCI: qcom-ep: Add support for SA8775P SoC 2023-10-30 10:50 ` Krzysztof Kozlowski @ 2023-10-30 12:22 ` Mrinmay Sarkar 0 siblings, 0 replies; 3+ messages in thread From: Mrinmay Sarkar @ 2023-10-30 12:22 UTC (permalink / raw) To: Krzysztof Kozlowski, agross, andersson, krzysztof.kozlowski+dt, conor+dt, konrad.dybcio, mani Cc: quic_shazhuss, quic_nitegupt, quic_ramkri, quic_nayiluri, dmitry.baryshkov, robh, quic_krichai, quic_vbadigan, quic_parass, quic_schintav, Bjorn Helgaas, Lorenzo Pieralisi, Krzysztof Wilczyński, Kishon Vijay Abraham I, linux-pci, linux-arm-msm, devicetree, linux-kernel, mhi On 10/30/2023 4:20 PM, Krzysztof Kozlowski wrote: > On 30/10/2023 11:19, Mrinmay Sarkar wrote: >> On 10/27/2023 7:20 PM, Krzysztof Kozlowski wrote: >>> On 27/10/2023 15:33, Mrinmay Sarkar wrote: >>>> Add devicetree bindings support for SA8775P SoC. It has DMA register >>>> space and dma interrupt to support HDMA. >>>> >>>> Signed-off-by: Mrinmay Sarkar <quic_msarkar@quicinc.com> >>> Unfortunately I do not see any of my comment addressed. :( >>> >>> This is a friendly reminder during the review process. >>> >>> It seems my or other reviewer's previous comments were not fully >>> addressed. Maybe the feedback got lost between the quotes, maybe you >>> just forgot to apply it. Please go back to the previous discussion and >>> either implement all requested changes or keep discussing them. >>> >>> Thank you. >>> >>> Best regards, >>> Krzysztof >> Thanks Krzysztof for your review and patience. >> Sorry I missed your previous comment. > Multiple comments. Also from Mani and maybe from others? I have discussed and addressed all the comments from others. As per the discussions. Updated commit messages and made necessary changes in dtsi node. please correct me otherwise. >> If I understand correctly by constraining IO space/interrupt, >> you mean to add maxItems for reg and interrupt for other variants. >> If so, I verified adding maxItems for these properties and dtb check >> seems to be good. I will post the same in the next patch series. >> >> Thanks, >> Mrinmay > Best regards, > Krzysztof Thanks, Mrinmay > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-30 12:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1698413592-26523-1-git-send-email-quic_msarkar@quicinc.com>
[not found] ` <1698413592-26523-2-git-send-email-quic_msarkar@quicinc.com>
[not found] ` <45b8f4e1-b915-42f2-aa03-03cc9d1be9f7@linaro.org>
2023-10-30 10:19 ` [PATCH v4 1/4] dt-bindings: PCI: qcom-ep: Add support for SA8775P SoC Mrinmay Sarkar
2023-10-30 10:50 ` Krzysztof Kozlowski
2023-10-30 12:22 ` Mrinmay Sarkar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®