From: Mario Limonciello <mario.limonciello@amd.com>
To: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>,
harry.wentland@amd.com
Cc: sunpeng.li@amd.com, siqueira@igalia.com,
alexander.deucher@amd.com, christian.koenig@amd.com,
airlied@gmail.com, simona@ffwll.ch, alex.hung@amd.com,
Wayne.Lin@amd.com, timur.kristof@gmail.com, superm1@kernel.org,
aurabindo.pillai@amd.com, ivan.lipski@amd.com,
chen-yu.chen@amd.com, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amd/display: Avoid using zero AC/DC brightness levels
Date: Thu, 28 May 2026 22:17:05 +0100 [thread overview]
Message-ID: <4ebe7f6b-aa32-4441-84db-1b09cc69c075@amd.com> (raw)
In-Reply-To: <20260526210048.1162477-1-edson.drosdeck@gmail.com>
On 5/26/26 22:00, Edson Juliano Drosdeck wrote:
> Some systems report zero AC/DC brightness levels during
> backlight initialization, causing the panel brightness to
> start at the minimum level on boot.
>
> Only use the firmware brightness levels when both AC and DC
> values are non-zero
>
> Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
Can you please share an acpidump and an EDID into a bug report to look at?
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 5fc5d5608506..f947ce2a8625 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -5380,7 +5380,9 @@ amdgpu_dm_register_backlight_device(struct amdgpu_dm_connector *aconnector)
> }
>
> caps = &dm->backlight_caps[aconnector->bl_idx];
> - if (get_brightness_range(caps, &min, &max)) {
> + if (get_brightness_range(caps, &min, &max) &&
> + caps->ac_level > 0 &&
> + caps->dc_level > 0) {
> if (power_supply_is_system_supplied() > 0)
> props.brightness = DIV_ROUND_CLOSEST((max - min) * caps->ac_level, 100);
> else
next prev parent reply other threads:[~2026-05-28 23:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 21:00 Edson Juliano Drosdeck
2026-05-28 21:17 ` Mario Limonciello [this message]
2026-05-29 19:13 ` edson drosdeck
2026-06-03 19:23 ` Mario Limonciello
2026-06-08 18:25 ` edson drosdeck
2026-06-08 18:34 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ebe7f6b-aa32-4441-84db-1b09cc69c075@amd.com \
--to=mario.limonciello@amd.com \
--cc=Wayne.Lin@amd.com \
--cc=airlied@gmail.com \
--cc=alex.hung@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aurabindo.pillai@amd.com \
--cc=chen-yu.chen@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=edson.drosdeck@gmail.com \
--cc=harry.wentland@amd.com \
--cc=ivan.lipski@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=siqueira@igalia.com \
--cc=sunpeng.li@amd.com \
--cc=superm1@kernel.org \
--cc=timur.kristof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®