mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: edson drosdeck <edson.drosdeck@gmail.com>
Cc: harry.wentland@amd.com, sunpeng.li@amd.com, siqueira@igalia.com,
	alexander.deucher@amd.com, christian.koenig@amd.com,
	airlied@gmail.com, simona@ffwll.ch, alex.hung@amd.com,
	Wayne.Lin@amd.com, timur.kristof@gmail.com, superm1@kernel.org,
	aurabindo.pillai@amd.com, ivan.lipski@amd.com,
	chen-yu.chen@amd.com, amd-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amd/display: Avoid using zero AC/DC brightness levels
Date: Wed, 3 Jun 2026 14:23:30 -0500	[thread overview]
Message-ID: <d4cfb50b-3b70-4393-9d95-04566767c778@amd.com> (raw)
In-Reply-To: <CAMSsBRw16QVwXCWWq0aeoKcqe9soBF9x_un6fGj5A4P+iVCv-Q@mail.gmail.com>



On 5/29/26 14:13, edson drosdeck wrote:
> Hi,
> 
> Please find attached the requested ACPI dump and EDID files:
> 
> acpidump.txt
> edid.txt
> 
> Thanks for taking a look.

Sorry for my delay.  I looked through your acpidump and you don't have 
an ATIF method (which would indicate preferred brightness values for AC 
and DC).

I had expected this case is handled by 
amdgpu_dm_update_backlight_caps(), but it appears that only sets min/max 
not ac/dc default levels.

Can you see if this helps?

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c 
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 832223c06b3f5..e2831bf48eaab 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -5213,6 +5213,8 @@ static void amdgpu_dm_update_backlight_caps(struct 
amdgpu_display_manager *dm,
         if (!caps->caps_valid) {
                 caps->min_input_signal = AMDGPU_DM_DEFAULT_MIN_BACKLIGHT;
                 caps->max_input_signal = AMDGPU_DM_DEFAULT_MAX_BACKLIGHT;
+               caps->ac_level = 50;
+               caps->dc_level = 50;
                 caps->caps_valid = true;
         }
  #else



  reply	other threads:[~2026-06-03 19:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26 21:00 Edson Juliano Drosdeck
2026-05-28 21:17 ` Mario Limonciello
2026-05-29 19:13   ` edson drosdeck
2026-06-03 19:23     ` Mario Limonciello [this message]
2026-06-08 18:25       ` edson drosdeck
2026-06-08 18:34         ` Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4cfb50b-3b70-4393-9d95-04566767c778@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Wayne.Lin@amd.com \
    --cc=airlied@gmail.com \
    --cc=alex.hung@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=aurabindo.pillai@amd.com \
    --cc=chen-yu.chen@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=edson.drosdeck@gmail.com \
    --cc=harry.wentland@amd.com \
    --cc=ivan.lipski@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=siqueira@igalia.com \
    --cc=sunpeng.li@amd.com \
    --cc=superm1@kernel.org \
    --cc=timur.kristof@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®