mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Simmons, James A." <simmonsja@ornl.gov>
To: "'Dan Carpenter'" <dan.carpenter@oracle.com>,
	James Simmons <jsimmons@infradead.org>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	James Simmons <uja.ornl@yahoo.com>,
	James Simmons <uja.ornl@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Oleg Drokin <oleg.drokin@intel.com>,
	"HPDD-discuss@ml01.01.org" <HPDD-discuss@ml01.01.org>,
	"lustre-devel@lists.lustre.org" <lustre-devel@lists.lustre.org>
Subject: RE: [lustre-devel] [PATCH 1/3] staging:lustre: remove tcpip abstraction from libcfs
Date: Fri, 22 May 2015 15:08:44 +0000	[thread overview]
Message-ID: <4ebf8ca4e2dd466c8ff68291b6670515@EXCHCS32.ornl.gov> (raw)
In-Reply-To: <20150522111536.GA19434@mwanda>

>This patch does a lot of stuff all at once and it is hard to review.  It
>could easily be broken into patches which are easy to review.

I have more very large patches. With breaking them up that means you are
going to see hundreds of patches coming from me. 

>Ok in this next section we move functions around and rename them but
>also introduce some bad changes in the new function.

Thanks for pointing out these bugs. We are still carrying these bugs in the
OpenSFS branch. Once you approve these changes I will sync up lib-socket.c
in the OpenSFS branch.

P.S
      Does the 3rd patch look okay to you?

  reply	other threads:[~2015-05-22 15:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-21 22:46 James Simmons
2015-05-22 11:15 ` Dan Carpenter
2015-05-22 15:08   ` Simmons, James A. [this message]
2015-05-22 15:39     ` [lustre-devel] " Dan Carpenter
2015-05-22 21:40     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ebf8ca4e2dd466c8ff68291b6670515@EXCHCS32.ornl.gov \
    --to=simmonsja@ornl.gov \
    --cc=HPDD-discuss@ml01.01.org \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jsimmons@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    --cc=oleg.drokin@intel.com \
    --cc=uja.ornl@gmail.com \
    --cc=uja.ornl@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome