From: Kamil Konieczny <k.konieczny@partner.samsung.com>
To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Krzysztof Kozlowski <krzk@kernel.org>,
Vladimir Zapolskiy <vz@mleia.com>,
"David S. Miller" <davem@davemloft.net>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] crypto: s5p-sss: Add HASH support for Exynos
Date: Mon, 16 Oct 2017 18:40:16 +0200 [thread overview]
Message-ID: <4ed6e790-891a-42de-8b6b-7318c8a891fd@partner.samsung.com> (raw)
In-Reply-To: <4e9717c5-43d1-46d1-60ed-ea8168a91cc4@mentor.com>
Hello Vladimir,
>>[snip]
>> -static struct s5p_aes_dev *s5p_dev;
>> +enum hash_op {
>> + HASH_OP_UPDATE = 1,
>> + HASH_OP_FINAL = 2
>> +};
>
> If this type is not going to be extended, then I'd rather suggest to
> use a boolean correspondent field in the struct s5p_hash_reqctx instead
> of a new introduced type. [...]
In prevoious mail I wrote 'op_final', but this will actually be 'op_update'.
--
Best regards,
Kamil Konieczny
Samsung R&D Institute Poland
prev parent reply other threads:[~2017-10-16 16:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171009111232eucas1p1d17afaae66931a7dd234dbfa1d5a193f@eucas1p1.samsung.com>
2017-10-09 11:12 ` Kamil Konieczny
2017-10-09 18:52 ` Krzysztof Kozlowski
2017-10-12 11:45 ` Vladimir Zapolskiy
2017-10-16 16:19 ` Kamil Konieczny
2017-10-16 16:40 ` Kamil Konieczny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ed6e790-891a-42de-8b6b-7318c8a891fd@partner.samsung.com \
--to=k.konieczny@partner.samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=krzk@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=vladimir_zapolskiy@mentor.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®