From: "Kumar, Udit" <u-kumar1@ti.com>
To: Esteban Blanc <eblanc@baylibre.com>,
"Menon, Nishanth" <nm@ti.com>,
"Raghavendra, Vignesh" <vigneshr@ti.com>,
"kristo@kernel.org" <kristo@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jneanne@baylibre.com" <jneanne@baylibre.com>,
"aseketeli@baylibre.com" <aseketeli@baylibre.com>,
"jpanis@baylibre.com" <jpanis@baylibre.com>,
"Tonking, Reid" <reidt@ti.com>
Subject: RE: [PATCH v4 1/6] arm64: dts: ti: k3-j7200-som-p0: Add TP6594 family PMICs
Date: Wed, 2 Aug 2023 04:04:15 +0000 [thread overview]
Message-ID: <4efd1c627a934915b4e9b313879d83e9@ti.com> (raw)
In-Reply-To: <20230727130908.10656-2-eblanc@baylibre.com>
Hi Esteban,
>This patch adds support for TPS6594 PMIC family on wakup I2C0 bus.
>Theses devices provides regulators (bucks and LDOs), but also
>GPIOs, a RTC, a watchdog, an ESM (Error Signal Monitor)
>which monitors the SoC error output signal, and a PFSM
>(Pre-configurable Finite State Machine) which manages the
>operational modes of the PMIC.
>
>Signed-off-by: Esteban Blanc <eblanc@baylibre.com>
>---
> arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi | 157 ++++++++++++++++++++
> 1 file changed, 157 insertions(+)
>
>diff --git a/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi
>b/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi
>index b37f4f88ece4..e45d97cc41a5 100644
>--- a/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi
>+++ b/arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi
>@@ -127,6 +127,14 @@ J721E_WKUP_IOPAD(0x9c, PIN_INPUT_PULLUP, 0) /*
>(H21) WKUP_I2C0_SDA */
> };
> };
>
>+&wkup_pmx3 {
>+ pmic_irq_pins_default: pmic-irq-pins-default {
>+ pinctrl-single,pins = <
>+ J721E_WKUP_IOPAD(0x1c, PIN_INPUT, 7) /* (E18)
>WKUP_GPIO0_84 */
Could you use 0x01c format instead of 0x1c,
and similar format in other patches in this series too.
Rest LGTM
>+ >;
>+ };
>+};
>+
[..]
next prev parent reply other threads:[~2023-08-02 4:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 13:09 [PATCH v4 0/6] Add TPS6594 PMIC support on several boards Esteban Blanc
2023-07-27 13:09 ` [PATCH v4 1/6] arm64: dts: ti: k3-j7200-som-p0: Add TP6594 family PMICs Esteban Blanc
2023-08-02 4:04 ` Kumar, Udit [this message]
2023-07-27 13:09 ` [PATCH v4 2/6] arm64: dts: ti: k3-j721s2-som-p0: " Esteban Blanc
2023-08-03 10:31 ` Kumar, Udit
2023-08-03 11:13 ` Vaishnav Achath
2023-08-03 12:43 ` Kumar, Udit
2023-07-27 13:09 ` [PATCH v4 3/6] arm64: dts: ti: k3-j721e-som-p0: " Esteban Blanc
2023-08-03 15:52 ` jerome Neanne
2023-07-27 13:09 ` [PATCH v4 4/6] arm64: dts: ti: k3-j784s4-evm: Fix interrupt ranges for TPS6594 PMIC Esteban Blanc
2023-07-27 13:09 ` [PATCH v4 5/6] arm64: dts: ti: k3-j784s4-evm: Add support " Esteban Blanc
2023-07-27 13:09 ` [PATCH v4 6/6] arm64: dts: ti: k3-am62a7-sk: Add support for TPS6593 PMIC Esteban Blanc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4efd1c627a934915b4e9b313879d83e9@ti.com \
--to=u-kumar1@ti.com \
--cc=aseketeli@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=eblanc@baylibre.com \
--cc=jneanne@baylibre.com \
--cc=jpanis@baylibre.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=reidt@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®