Re: [PATCH v4 1/3] ASoC: codecs: lpass-wsa-macro: Switch to PM clock framework for runtime PM

[Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>]

On 5/22/2026 4:12 PM, Konrad Dybcio wrote:
> On 5/19/26 4:33 PM, Mark Brown wrote:
>> On Mon, May 18, 2026 at 01:47:36PM +0530, Ajay Kumar Nandam wrote:
>>> Convert the LPASS WSA macro codec driver to use the PM clock framework
>>> for runtime power management.
>>
>>> The driver now relies on pm_clk helpers and runtime PM instead of
>>> manually enabling and disabling macro, dcodec, mclk, npl, and fsgen
>>> clocks. Runtime suspend and resume handling is delegated to the PM
>>> core via pm_clk_suspend() and pm_clk_resume(), while existing runtime
>>> PM callbacks continue to manage regcache state.
>>
>>> +	ret = devm_pm_clk_create(dev);
>>
>> The !PM_CLK stub for this just returns -EINVAL so if that's not enabled
>> then none of the clocks will be enabled, the driver needs a dependency
>> adding.
> 
> This goes for both the drivers
> 
> I don't think I have other comments with that fixed
> 
> Konrad

ACK, Thank you


Thanks
Ajay