mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Heiner Kallweit <hkallweit1@gmail.com>,
	Sudeep Holla <sudeep.holla@arm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] add missing "source" line for firmware subdirectory in drivers/Kconfig
Date: Tue, 28 Nov 2017 09:09:29 -0800	[thread overview]
Message-ID: <4f19cd91-997e-45ef-309d-2d1b83ae632e@infradead.org> (raw)
In-Reply-To: <db202e46-8521-9514-e0e9-416fe90a7927@googlemail.com>

On 11/27/2017 11:12 PM, Heiner Kallweit wrote:
> I have a little bit of a hard time to find the right addressee for
> this patch because there is no maintainer entry for drivers/firmware.
> Can you apply the following through your tree?
> 
> Add missing entry for firmware subdirectory in drivers/Kconfig.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>]

Hi,
Why do you need this patch?  You should explain that in the (missing)
patch description.

I suppose that it could be done like this, but currently any $ARCH that
wants to use drivers/firmware/Kconfig does so in the arch/$ARCH/Kconfig file:

arch> grep firmware/Kconfig */Kconfig
arm/Kconfig:source "arch/arm/firmware/Kconfig"
arm/Kconfig:source "drivers/firmware/Kconfig"
arm64/Kconfig:source "drivers/firmware/Kconfig"
blackfin/Kconfig:source "drivers/firmware/Kconfig"
ia64/Kconfig:source "drivers/firmware/Kconfig"
mips/Kconfig:source "drivers/firmware/Kconfig"
x86/Kconfig:source "drivers/firmware/Kconfig"

so all of these would need to be removed.

> ---
>  drivers/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/Kconfig b/drivers/Kconfig
> index 152744c5e..a506867d9 100644
> --- a/drivers/Kconfig
> +++ b/drivers/Kconfig
> @@ -39,6 +39,8 @@ source "drivers/message/fusion/Kconfig"
>  
>  source "drivers/firewire/Kconfig"
>  
> +source "drivers/firmware/Kconfig"
> +
>  source "drivers/macintosh/Kconfig"
>  
>  source "drivers/net/Kconfig"
> 


-- 
~Randy

  reply	other threads:[~2017-11-28 17:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-28  7:12 Heiner Kallweit
2017-11-28 17:09 ` Randy Dunlap [this message]
2017-11-28 19:36   ` Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f19cd91-997e-45ef-309d-2d1b83ae632e@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®