From: "André Draszik" <andre.draszik@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH 1/2] regulator: s2mps11: drop redundant sanity checks in s2mpg10_of_parse_cb()
Date: Tue, 10 Feb 2026 05:59:20 +0000 [thread overview]
Message-ID: <4f1b1d857c0ee17436cd61e97219f508bd89f917.camel@linaro.org> (raw)
In-Reply-To: <170a820d-b987-4fd7-acca-ac88bab9e243@kernel.org>
Hi Krzysztof,
On Mon, 2026-02-09 at 17:09 +0100, Krzysztof Kozlowski wrote:
> On 09/02/2026 16:07, André Draszik wrote:
> > The sanity checks being removed in this commit are useless as earlier
> > code checks for out-of-bounds conditions already. They also are
> > incorrect (as they're off-by-one).
> >
> > Simply remove this incorrect code.
> >
> > No functional change.
>
> If they are incorrect then how it could be "no functional change"? To me
> original code looks buggy and this is a fix. Fix must have functional
> change...
Earlier code already checks for all conditions, including all error cases.
So the code being removed here has no effect, as any potential error it
could catch will already have been caught by earlier code. Removing it
therefore doesn't change behaviour or functionality.
I can reword to 'incomplete test' instead of 'incorrect code' if you think
that's more clear?
Cheers,
Andre'
next prev parent reply other threads:[~2026-02-10 5:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 15:07 [PATCH 0/2] regulator: s2mps11: two small bug fixes (s2mpg1x) André Draszik
2026-02-09 15:07 ` [PATCH 1/2] regulator: s2mps11: drop redundant sanity checks in s2mpg10_of_parse_cb() André Draszik
2026-02-09 16:09 ` Krzysztof Kozlowski
2026-02-10 5:59 ` André Draszik [this message]
2026-02-10 7:28 ` Krzysztof Kozlowski
2026-02-10 9:37 ` André Draszik
2026-02-10 10:51 ` Krzysztof Kozlowski
2026-02-10 11:35 ` André Draszik
2026-02-10 11:39 ` Krzysztof Kozlowski
2026-02-09 15:07 ` [PATCH 2/2] regulator: s2mps11: fix pctrlsel macro usage " André Draszik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f1b1d857c0ee17436cd61e97219f508bd89f917.camel@linaro.org \
--to=andre.draszik@linaro.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®