* [PATCH] KVM: x86: Bug the VM, not the kernel, if the ISR count {under,over}flows
@ 2026-06-18 18:53 Sean Christopherson
2026-06-19 7:30 ` Huang, Kai
2026-06-24 9:53 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Sean Christopherson @ 2026-06-18 18:53 UTC (permalink / raw)
To: Sean Christopherson, Paolo Bonzini; +Cc: kvm, linux-kernel
Bug the VM, not the host kernel, if KVM's ISR count {under,over}flows when
tracking in-flight ISRs. There is zero danger to the host if KVM messes up
its IRQ tracking.
Signed-off-by: Sean Christopherson <seanjc@google.com>
---
arch/x86/kvm/lapic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
index 9d2df8623f6d..e733ca6b9792 100644
--- a/arch/x86/kvm/lapic.c
+++ b/arch/x86/kvm/lapic.c
@@ -767,7 +767,7 @@ static inline void apic_set_isr(int vec, struct kvm_lapic *apic)
kvm_x86_call(hwapic_isr_update)(apic->vcpu, vec);
else {
++apic->isr_count;
- BUG_ON(apic->isr_count > MAX_APIC_VECTOR);
+ KVM_BUG_ON(apic->isr_count > MAX_APIC_VECTOR, apic->vcpu->kvm);
/*
* ISR (in service register) bit is set when injecting an interrupt.
* The highest vector is injected. Thus the latest bit set matches
@@ -808,7 +808,7 @@ static inline void apic_clear_isr(int vec, struct kvm_lapic *apic)
kvm_x86_call(hwapic_isr_update)(apic->vcpu, apic_find_highest_isr(apic));
else {
--apic->isr_count;
- BUG_ON(apic->isr_count < 0);
+ KVM_BUG_ON(apic->isr_count < 0, apic->vcpu->kvm);
apic->highest_isr_cache = -1;
}
}
base-commit: 9d4853b044beefa21c4ee3e18c40653601a64ced
--
2.55.0.rc0.738.g0c8ab3ebcc-goog
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] KVM: x86: Bug the VM, not the kernel, if the ISR count {under,over}flows
2026-06-18 18:53 [PATCH] KVM: x86: Bug the VM, not the kernel, if the ISR count {under,over}flows Sean Christopherson
@ 2026-06-19 7:30 ` Huang, Kai
2026-06-24 9:53 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Huang, Kai @ 2026-06-19 7:30 UTC (permalink / raw)
To: pbonzini, seanjc; +Cc: kvm, linux-kernel
On Thu, 2026-06-18 at 11:53 -0700, Sean Christopherson wrote:
> Bug the VM, not the host kernel, if KVM's ISR count {under,over}flows when
> tracking in-flight ISRs. There is zero danger to the host if KVM messes up
> its IRQ tracking.
>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
Reviewed-by: Kai Huang <kai.huang@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] KVM: x86: Bug the VM, not the kernel, if the ISR count {under,over}flows
2026-06-18 18:53 [PATCH] KVM: x86: Bug the VM, not the kernel, if the ISR count {under,over}flows Sean Christopherson
2026-06-19 7:30 ` Huang, Kai
@ 2026-06-24 9:53 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2026-06-24 9:53 UTC (permalink / raw)
To: Sean Christopherson; +Cc: kvm, linux-kernel
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-24 9:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-18 18:53 [PATCH] KVM: x86: Bug the VM, not the kernel, if the ISR count {under,over}flows Sean Christopherson
2026-06-19 7:30 ` Huang, Kai
2026-06-24 9:53 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®