mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <pure.logic@nexus-software.ie>
To: Trent Piepho <tpiepho@impinj.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"alexandre.belloni@free-electrons.com"
	<alexandre.belloni@free-electrons.com>
Cc: "shawn.guo@linaro.org" <shawn.guo@linaro.org>,
	"stefan@agner.ch" <stefan@agner.ch>,
	"bianpan2016@163.com" <bianpan2016@163.com>,
	"a.zummo@towertech.it" <a.zummo@towertech.it>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"guy.shapiro@mobi-wize.com" <guy.shapiro@mobi-wize.com>,
	"Frank.Li@freescale.com" <Frank.Li@freescale.com>,
	"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>
Subject: Re: [RESEND] rtc: snvs: Fix usage of snvs_rtc_enable
Date: Mon, 2 Apr 2018 23:51:12 +0100	[thread overview]
Message-ID: <4f9434c7-6977-caef-2fac-5da79364304b@nexus-software.ie> (raw)
In-Reply-To: <1522450739.10662.278.camel@impinj.com>

On 30/03/18 23:59, Trent Piepho wrote:
> However, I think that even if the driver fails to probe if there is a
> timeout at probe time, it's still possible to hang later if there are
> not limits to the hardware polling loops, such as the ones I added.

I agree with your patch in principle for this the reason you've outlined.

My patch though should still be applied to fix non-starting @ source.

/aside - I don't have your patch in my inbox - if you could resend and 
cc me I'll review it for you.

---
bod

  reply	other threads:[~2018-04-02 22:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-28 19:14 [RESEND] [PATCH] " Bryan O'Donoghue
2018-03-29  0:12 ` [RESEND] " Trent Piepho
2018-03-29  1:53   ` Bryan O'Donoghue
2018-03-30 22:59     ` Trent Piepho
2018-04-02 22:51       ` Bryan O'Donoghue [this message]
2018-04-03 14:42         ` Alexandre Belloni
2018-03-29  2:18 ` [RESEND] [PATCH] " Shawn Guo
2018-04-03 14:56 ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f9434c7-6977-caef-2fac-5da79364304b@nexus-software.ie \
    --to=pure.logic@nexus-software.ie \
    --cc=Frank.Li@freescale.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=bianpan2016@163.com \
    --cc=guy.shapiro@mobi-wize.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    --cc=stable@vger.kernel.org \
    --cc=stefan@agner.ch \
    --cc=tpiepho@impinj.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®