From: Bryan O'Donoghue <pure.logic@nexus-software.ie>
To: Trent Piepho <tpiepho@impinj.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alexandre.belloni@free-electrons.com"
<alexandre.belloni@free-electrons.com>
Cc: "shawn.guo@linaro.org" <shawn.guo@linaro.org>,
"stefan@agner.ch" <stefan@agner.ch>,
"bianpan2016@163.com" <bianpan2016@163.com>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"guy.shapiro@mobi-wize.com" <guy.shapiro@mobi-wize.com>,
"Frank.Li@freescale.com" <Frank.Li@freescale.com>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>
Subject: Re: [RESEND] rtc: snvs: Fix usage of snvs_rtc_enable
Date: Thu, 29 Mar 2018 02:53:44 +0100 [thread overview]
Message-ID: <f380bc29-c8dd-5c20-efc4-ffc0ad69b8d6@nexus-software.ie> (raw)
In-Reply-To: <1522282337.10662.268.camel@impinj.com>
On 29/03/18 01:12, Trent Piepho wrote:
> I sent a patch a couple weeks ago that addressed a similar issue, see
> https://patchwork.ozlabs.org/patch/887090/
>
> Does this also fix the problem you see?
It breaks the endless loop that happens later on in the RTC read path.
This patch though is about fixing the bug with not handling the enable
of the snvs_rtc_enable() correctly, which is why it should be applied.
The right flow is to handle the error on snvs_rtc_enable() as soon as it
happens as opposed wait for read() to -ETIMEDOUT.
> I think what you've done will prevent the driver from loading if the
> clock is not working, but if the clock does not tick properly after
> loading, there are still points (snvs_rtc_read_time for one) that will
> lock up in the kernel.
I'll dig out your patch and give it a review.
---
bod
next prev parent reply other threads:[~2018-03-29 1:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 19:14 [RESEND] [PATCH] " Bryan O'Donoghue
2018-03-29 0:12 ` [RESEND] " Trent Piepho
2018-03-29 1:53 ` Bryan O'Donoghue [this message]
2018-03-30 22:59 ` Trent Piepho
2018-04-02 22:51 ` Bryan O'Donoghue
2018-04-03 14:42 ` Alexandre Belloni
2018-03-29 2:18 ` [RESEND] [PATCH] " Shawn Guo
2018-04-03 14:56 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f380bc29-c8dd-5c20-efc4-ffc0ad69b8d6@nexus-software.ie \
--to=pure.logic@nexus-software.ie \
--cc=Frank.Li@freescale.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=bianpan2016@163.com \
--cc=guy.shapiro@mobi-wize.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=stable@vger.kernel.org \
--cc=stefan@agner.ch \
--cc=tpiepho@impinj.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®