Re: [PATCH 3/3] arm64: dts: qcom: sm8450-hdk: add sound support

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 14/11/2022 16:39, Konrad Dybcio wrote:
> 
> On 14/11/2022 16:21, Krzysztof Kozlowski wrote:
>> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>>
>> Add sound support to SM8450 HDK board.  Tested setup so far is only two
>> speakers (working) and head-phones (only one channel working).
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> Co-developed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>   arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 161 ++++++++++++++++++++++++
>>   1 file changed, 161 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
>> index 4d75f9db08c2..c177283b6764 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
>> @@ -6,6 +6,8 @@
>>   /dts-v1/;
>>   
>>   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>> +#include <dt-bindings/sound/qcom,q6afe.h>
>> +#include <dt-bindings/sound/qcom,q6asm.h>
>>   #include "sm8450.dtsi"
>>   
>>   / {
>> @@ -421,6 +423,147 @@ &uart7 {
>>   	status = "okay";
>>   };
>>   
>> +&soc {
> 
> soc should go before uart alphabetically.
> 
> 
> Other than that:
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> 
> 

Ack

Best regards,
Krzysztof