mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Maciej Purski <m.purski@samsung.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] component: add debugfs support
Date: Thu, 30 Nov 2017 14:21:19 +0100	[thread overview]
Message-ID: <4fa2267d-462b-ebef-7504-508084f4797f@samsung.com> (raw)
In-Reply-To: <20171130125416.GB10595@n2100.armlinux.org.uk>



On 11/30/2017 01:54 PM, Russell King - ARM Linux wrote:
> On Thu, Nov 30, 2017 at 01:48:32PM +0100, Maciej Purski wrote:
>> Currently there is no information in any vfs about which devices
>> a master component consists of, what makes debugging hard if
>> one of the component devices fails to register.
>>
>> Add 'device_component' directory to debugfs. Create a new file for each
>> component master, when it has been added. Remove it on a master
>> deletion. Show a list of devices required by the given master and their
>> status (registered or not). This provides an easy way to check, which
>> device has failed to register if the given master device is not
>> available in the system.
>>
>> Signed-off-by: Maciej Purski <m.purski@samsung.com>
>> ---
>> Changes in v4:
>> - fix and expand commit message
>> - inline no-op functions
> 
> inline on static functions makes no sense - the compiler itself is at
> liberty to inline any static function that it thinks would benefit,
> and it is likely to do so with such a simple function.
> 
> Generally we prefer to omit "inline" in .c files and let the compiler
> decide whether to inline or not.
> 
> What was the reason for making this change?  Do you have a case where
> this doesn't happen?
> 
I don't have any case. I just thought this would be more obvious, but if the 
general preference is to omit "inline", I'll fix this in the next version. Thanks.

Best regards,

Maciej

      reply	other threads:[~2017-11-30 13:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20171130124906eucas1p2a671ee7d62ddebe9fde3a5def2d97f44@eucas1p2.samsung.com>
2017-11-30 12:48 ` Maciej Purski
2017-11-30 12:54   ` Russell King - ARM Linux
2017-11-30 13:21     ` Maciej Purski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4fa2267d-462b-ebef-7504-508084f4797f@samsung.com \
    --to=m.purski@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=m.szyprowski@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®