* [PATCH][next] drm/vmwgfx: remove redundant assignment to sub_res
@ 2019-06-24 22:44 Colin King
2019-07-01 21:13 ` Deepak Singh Rawat
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2019-06-24 22:44 UTC (permalink / raw)
To: VMware Graphics, Thomas Hellstrom, David Airlie, Daniel Vetter,
dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable sub_res is initialized to a value that is never read and it
is re-assigned later in a for-loop. The initialization is redundant
and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
index 862ca44680ca..3257ba689d93 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
@@ -1914,7 +1914,7 @@ static void vmw_surface_tex_dirty_range_add(struct vmw_resource *res,
} else {
/* Dirty range covers multiple sub-resources */
struct svga3dsurface_loc loc_min, loc_max;
- u32 sub_res = loc1.sub_resource;
+ u32 sub_res;
svga3dsurface_max_loc(cache, loc1.sub_resource, &loc_max);
vmw_subres_dirty_add(dirty, &loc1, &loc_max);
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH][next] drm/vmwgfx: remove redundant assignment to sub_res
2019-06-24 22:44 [PATCH][next] drm/vmwgfx: remove redundant assignment to sub_res Colin King
@ 2019-07-01 21:13 ` Deepak Singh Rawat
0 siblings, 0 replies; 2+ messages in thread
From: Deepak Singh Rawat @ 2019-07-01 21:13 UTC (permalink / raw)
To: Colin King, Linux-graphics-maintainer, Thomas Hellstrom,
David Airlie, Daniel Vetter, dri-devel
Cc: kernel-janitors, linux-kernel
Hi Colin,
Reviewed-by: Deepak Rawat <drawat@vmware.com>
Thanks,
Deepak
On Mon, 2019-06-24 at 23:44 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable sub_res is initialized to a value that is never read and it
> is re-assigned later in a for-loop. The initialization is redundant
> and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
> b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
> index 862ca44680ca..3257ba689d93 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
> @@ -1914,7 +1914,7 @@ static void
> vmw_surface_tex_dirty_range_add(struct vmw_resource *res,
> } else {
> /* Dirty range covers multiple sub-resources */
> struct svga3dsurface_loc loc_min, loc_max;
> - u32 sub_res = loc1.sub_resource;
> + u32 sub_res;
>
> svga3dsurface_max_loc(cache, loc1.sub_resource,
> &loc_max);
> vmw_subres_dirty_add(dirty, &loc1, &loc_max);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-01 21:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-24 22:44 [PATCH][next] drm/vmwgfx: remove redundant assignment to sub_res Colin King
2019-07-01 21:13 ` Deepak Singh Rawat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®