* [PATCH v1] wifi: mt76: mt7925: Fix null-ptr-deref in mt7925_thermal_init()
@ 2025-06-25 12:49 Henry Martin
2025-06-25 13:42 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 2+ messages in thread
From: Henry Martin @ 2025-06-25 12:49 UTC (permalink / raw)
To: huntazhang, jitxie, landonsun, nbd, lorenzo, ryder.lee,
shayne.chen, sean.wang, matthias.bgg, angelogioacchino.delregno
Cc: linux-wireless, linux-mediatek, linux-arm-kernel, linux-kernel,
Henry Martin
devm_kasprintf() returns NULL on error. Currently, mt7925_thermal_init()
does not check for this case, which results in a NULL pointer
dereference.
Add NULL check after devm_kasprintf() to prevent this issue.
Fixes: 396e41a74a88 ("wifi: mt76: mt7925: support temperature sensor")
Signed-off-by: Henry Martin <bsdhenryma@tencent.com>
---
drivers/net/wireless/mediatek/mt76/mt7925/init.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/init.c b/drivers/net/wireless/mediatek/mt76/mt7925/init.c
index 2a83ff59a968..4249bad83c93 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7925/init.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7925/init.c
@@ -52,6 +52,8 @@ static int mt7925_thermal_init(struct mt792x_phy *phy)
name = devm_kasprintf(&wiphy->dev, GFP_KERNEL, "mt7925_%s",
wiphy_name(wiphy));
+ if (!name)
+ return -ENOMEM;
hwmon = devm_hwmon_device_register_with_groups(&wiphy->dev, name, phy,
mt7925_hwmon_groups);
--
2.41.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1] wifi: mt76: mt7925: Fix null-ptr-deref in mt7925_thermal_init()
2025-06-25 12:49 [PATCH v1] wifi: mt76: mt7925: Fix null-ptr-deref in mt7925_thermal_init() Henry Martin
@ 2025-06-25 13:42 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 2+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-06-25 13:42 UTC (permalink / raw)
To: Henry Martin, huntazhang, jitxie, landonsun, nbd, lorenzo,
ryder.lee, shayne.chen, sean.wang, matthias.bgg
Cc: linux-wireless, linux-mediatek, linux-arm-kernel, linux-kernel,
Henry Martin
Il 25/06/25 14:49, Henry Martin ha scritto:
> devm_kasprintf() returns NULL on error. Currently, mt7925_thermal_init()
> does not check for this case, which results in a NULL pointer
> dereference.
>
> Add NULL check after devm_kasprintf() to prevent this issue.
>
> Fixes: 396e41a74a88 ("wifi: mt76: mt7925: support temperature sensor")
> Signed-off-by: Henry Martin <bsdhenryma@tencent.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-25 13:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-25 12:49 [PATCH v1] wifi: mt76: mt7925: Fix null-ptr-deref in mt7925_thermal_init() Henry Martin
2025-06-25 13:42 ` AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®