From: Faiz Abbas <faiz_abbas@ti.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Kishon <kishon@ti.com>, Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 1/4] mmc: sdhci-omap: Fix DCRC error handling during tuning
Date: Tue, 20 Nov 2018 12:58:06 +0530 [thread overview]
Message-ID: <4ff41f24-e152-521e-3fd7-0083b0d4ff98@ti.com> (raw)
In-Reply-To: <CAPDyKFo==Up-pTGZcjMvKWY70-m7i44A5Yr_qJjtpBFjWK8J5g@mail.gmail.com>
Hi Uffe
On 19/11/18 6:48 PM, Ulf Hansson wrote:
> On 19 November 2018 at 12:16, Faiz Abbas <faiz_abbas@ti.com> wrote:
>> Commit 7d33c3581536 ("mmc: sdhci-omap: Workaround for Errata i802")
>> disabled DCRC interrupts during tuning. This write to the interrupt
>> enable register gets overwritten in sdhci_prepare_data() and the
>> interrupt is not in fact disabled. Fix this by disabling the interrupt
>> in the host->ier variable.
>>
>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
>
> Should we have fixes/stable tag?
>
Ok. Will add that.
Thanks,
Faiz
next prev parent reply other threads:[~2018-11-20 7:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 11:16 [PATCH 0/4] Tuning Fixes for sdhci-omap Faiz Abbas
2018-11-19 11:16 ` [PATCH 1/4] mmc: sdhci-omap: Fix DCRC error handling during tuning Faiz Abbas
2018-11-19 13:18 ` Ulf Hansson
2018-11-20 7:28 ` Faiz Abbas [this message]
2018-11-20 4:53 ` Kishon Vijay Abraham I
2018-11-21 9:39 ` Faiz Abbas
2018-11-19 11:16 ` [PATCH 2/4] mmc: sdhci-omap: Add variable to indicate host is tuning Faiz Abbas
2018-11-19 13:18 ` Ulf Hansson
2018-11-20 12:58 ` Faiz Abbas
2018-11-19 11:16 ` [PATCH 3/4] mmc: sdhci-omap: Add platform specific reset callback Faiz Abbas
2018-11-20 5:00 ` Kishon Vijay Abraham I
2018-11-19 11:16 ` [PATCH 4/4] mmc: sdhci-omap: Remove redundant structure assignments Faiz Abbas
2018-11-20 5:01 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ff41f24-e152-521e-3fd7-0083b0d4ff98@ti.com \
--to=faiz_abbas@ti.com \
--cc=adrian.hunter@intel.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®