From: Kishon Vijay Abraham I <kishon@ti.com>
To: Faiz Abbas <faiz_abbas@ti.com>, <linux-kernel@vger.kernel.org>,
<linux-mmc@vger.kernel.org>
Cc: <ulf.hansson@linaro.org>, <adrian.hunter@intel.com>
Subject: Re: [PATCH 4/4] mmc: sdhci-omap: Remove redundant structure assignments
Date: Tue, 20 Nov 2018 10:31:35 +0530 [thread overview]
Message-ID: <e337e772-5581-c225-e1c1-58fa6d285988@ti.com> (raw)
In-Reply-To: <20181119111618.2745-5-faiz_abbas@ti.com>
On 19/11/18 4:46 PM, Faiz Abbas wrote:
> The sdhci_execute_tuning() function has assignment of
> private pointers multiple times. Remove the redundant assignment.
>
> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/mmc/host/sdhci-omap.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
> index bf268b38ddc8..b3cb39d0db6f 100644
> --- a/drivers/mmc/host/sdhci-omap.c
> +++ b/drivers/mmc/host/sdhci-omap.c
> @@ -295,10 +295,6 @@ static int sdhci_omap_execute_tuning(struct mmc_host *mmc, u32 opcode)
> int ret = 0;
> u32 reg;
>
> - pltfm_host = sdhci_priv(host);
> - omap_host = sdhci_pltfm_priv(pltfm_host);
> - dev = omap_host->dev;
> -
> /* clock tuning is not needed for upto 52MHz */
> if (ios->clock <= 52000000)
> return 0;
>
prev parent reply other threads:[~2018-11-20 5:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 11:16 [PATCH 0/4] Tuning Fixes for sdhci-omap Faiz Abbas
2018-11-19 11:16 ` [PATCH 1/4] mmc: sdhci-omap: Fix DCRC error handling during tuning Faiz Abbas
2018-11-19 13:18 ` Ulf Hansson
2018-11-20 7:28 ` Faiz Abbas
2018-11-20 4:53 ` Kishon Vijay Abraham I
2018-11-21 9:39 ` Faiz Abbas
2018-11-19 11:16 ` [PATCH 2/4] mmc: sdhci-omap: Add variable to indicate host is tuning Faiz Abbas
2018-11-19 13:18 ` Ulf Hansson
2018-11-20 12:58 ` Faiz Abbas
2018-11-19 11:16 ` [PATCH 3/4] mmc: sdhci-omap: Add platform specific reset callback Faiz Abbas
2018-11-20 5:00 ` Kishon Vijay Abraham I
2018-11-19 11:16 ` [PATCH 4/4] mmc: sdhci-omap: Remove redundant structure assignments Faiz Abbas
2018-11-20 5:01 ` Kishon Vijay Abraham I [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e337e772-5581-c225-e1c1-58fa6d285988@ti.com \
--to=kishon@ti.com \
--cc=adrian.hunter@intel.com \
--cc=faiz_abbas@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®