* [PATCH] dt-bindings: interconnect: qcom: Relax child node name pattern
@ 2026-10-28 8:12 Krzysztof Kozlowski
2026-10-28 8:26 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2026-10-28 8:12 UTC (permalink / raw)
To: Georgi Djakov, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Konrad Dybcio, Barnabas Czeman, Shawn Guo, Raviteja Laggyshetty,
Luca Weiss, Danila Tikhonov, linux-arm-msm, linux-pm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
Some Qualcomm SoCs interconnect nodes have a one child, thus that child
should be named 'interconnect' just like the parent, not
'interconnect-0' or 'interconnect-foo' (see Devicetree specification on
generic device node naming). Ideally the child should be just a
property, not patternProperties, but that would be an ABI change. Relax
the pattern for children to allow the correct naming.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
.../devicetree/bindings/interconnect/qcom,msm8939.yaml | 2 +-
.../devicetree/bindings/interconnect/qcom,msm8953.yaml | 2 +-
.../devicetree/bindings/interconnect/qcom,qcm2290.yaml | 3 +--
.../devicetree/bindings/interconnect/qcom,shikra.yaml | 3 +--
.../devicetree/bindings/interconnect/qcom,sm6115.yaml | 3 +--
.../devicetree/bindings/interconnect/qcom,sm6350-rpmh.yaml | 2 +-
.../devicetree/bindings/interconnect/qcom,sm7150-rpmh.yaml | 3 +--
7 files changed, 7 insertions(+), 11 deletions(-)
diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8939.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8939.yaml
index 534644cccdcb..f8ecfe60a8a3 100644
--- a/Documentation/devicetree/bindings/interconnect/qcom,msm8939.yaml
+++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8939.yaml
@@ -33,7 +33,7 @@ properties:
maxItems: 1
patternProperties:
- '^interconnect-[a-z0-9\-]+$':
+ '^interconnect(-[a-z0-9\-]+)?$':
type: object
$ref: qcom,rpm-common.yaml#
description:
diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8953.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8953.yaml
index 56cdb77b369a..538115048d99 100644
--- a/Documentation/devicetree/bindings/interconnect/qcom,msm8953.yaml
+++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8953.yaml
@@ -35,7 +35,7 @@ properties:
const: 2
patternProperties:
- '^interconnect-[a-z0-9\-]+$':
+ '^interconnect(-[a-z0-9\-]+)?$':
type: object
$ref: qcom,rpm-common.yaml#
unevaluatedProperties: false
diff --git a/Documentation/devicetree/bindings/interconnect/qcom,qcm2290.yaml b/Documentation/devicetree/bindings/interconnect/qcom,qcm2290.yaml
index b6c15314c5c5..72b060a4a193 100644
--- a/Documentation/devicetree/bindings/interconnect/qcom,qcm2290.yaml
+++ b/Documentation/devicetree/bindings/interconnect/qcom,qcm2290.yaml
@@ -26,9 +26,8 @@ properties:
- qcom,qcm2290-cnoc
- qcom,qcm2290-snoc
-# Child node's properties
patternProperties:
- '^interconnect-[a-z0-9]+$':
+ '^interconnect(-[a-z0-9\-]+)?$':
type: object
description:
The interconnect providers do not have a separate QoS register space,
diff --git a/Documentation/devicetree/bindings/interconnect/qcom,shikra.yaml b/Documentation/devicetree/bindings/interconnect/qcom,shikra.yaml
index a0c26de94ccf..456b56222866 100644
--- a/Documentation/devicetree/bindings/interconnect/qcom,shikra.yaml
+++ b/Documentation/devicetree/bindings/interconnect/qcom,shikra.yaml
@@ -31,9 +31,8 @@ properties:
minItems: 1
maxItems: 4
-# Child node's properties
patternProperties:
- '^interconnect-[a-z0-9]+$':
+ '^interconnect(-[a-z0-9\-]+)?$':
type: object
description:
The interconnect providers do not have a separate QoS register space,
diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sm6115.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sm6115.yaml
index cdae0acf3a1d..0024fd29c0bc 100644
--- a/Documentation/devicetree/bindings/interconnect/qcom,sm6115.yaml
+++ b/Documentation/devicetree/bindings/interconnect/qcom,sm6115.yaml
@@ -31,9 +31,8 @@ properties:
minItems: 1
maxItems: 4
-# Child node's properties
patternProperties:
- '^interconnect-[a-z0-9]+$':
+ '^interconnect(-[a-z0-9\-]+)?$':
type: object
description:
The interconnect providers do not have a separate QoS register space,
diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sm6350-rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sm6350-rpmh.yaml
index 2dc16e4293a9..c62816917862 100644
--- a/Documentation/devicetree/bindings/interconnect/qcom,sm6350-rpmh.yaml
+++ b/Documentation/devicetree/bindings/interconnect/qcom,sm6350-rpmh.yaml
@@ -32,7 +32,7 @@ properties:
maxItems: 2
patternProperties:
- '^interconnect-[a-z0-9\-]+$':
+ '^interconnect(-[a-z0-9\-]+)?$':
type: object
description:
The interconnect providers do not have a separate QoS register space,
diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sm7150-rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sm7150-rpmh.yaml
index 978930324bbf..ec08000abc96 100644
--- a/Documentation/devicetree/bindings/interconnect/qcom,sm7150-rpmh.yaml
+++ b/Documentation/devicetree/bindings/interconnect/qcom,sm7150-rpmh.yaml
@@ -34,9 +34,8 @@ properties:
reg:
maxItems: 1
-# Child node's properties
patternProperties:
- '^interconnect-[0-9]+$':
+ '^interconnect(-[0-9]+)?$':
type: object
description:
The interconnect providers do not have a separate QoS register space,
--
2.53.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] dt-bindings: interconnect: qcom: Relax child node name pattern
2026-10-28 8:12 [PATCH] dt-bindings: interconnect: qcom: Relax child node name pattern Krzysztof Kozlowski
@ 2026-10-28 8:26 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2026-10-28 8:26 UTC (permalink / raw)
To: Georgi Djakov, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Konrad Dybcio, Barnabas Czeman, Shawn Guo, Raviteja Laggyshetty,
Luca Weiss, Danila Tikhonov, linux-arm-msm, linux-pm, devicetree,
linux-kernel
On 28/10/2026 09:12, Krzysztof Kozlowski wrote:
> Some Qualcomm SoCs interconnect nodes have a one child, thus that child
> should be named 'interconnect' just like the parent, not
> 'interconnect-0' or 'interconnect-foo' (see Devicetree specification on
> generic device node naming). Ideally the child should be just a
> property, not patternProperties, but that would be an ABI change. Relax
> the pattern for children to allow the correct naming.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> .../devicetree/bindings/interconnect/qcom,msm8939.yaml | 2 +-
> .../devicetree/bindings/interconnect/qcom,msm8953.yaml | 2 +-
> .../devicetree/bindings/interconnect/qcom,qcm2290.yaml | 3 +--
> .../devicetree/bindings/interconnect/qcom,shikra.yaml | 3 +--
> .../devicetree/bindings/interconnect/qcom,sm6115.yaml | 3 +--
> .../devicetree/bindings/interconnect/qcom,sm6350-rpmh.yaml | 2 +-
> .../devicetree/bindings/interconnect/qcom,sm7150-rpmh.yaml | 3 +--
> 7 files changed, 7 insertions(+), 11 deletions(-)
>
As Sashiko points, this needs updates.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-28 8:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-28 8:12 [PATCH] dt-bindings: interconnect: qcom: Relax child node name pattern Krzysztof Kozlowski
2026-10-28 8:26 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®