From: Philipp Klocke <Phil_K97@gmx.de>
To: philipp.reisner@linbit.com, lars.ellenberg@linbit.com, arnd@arndb.de
Cc: drbd-dev@lists.linbit.com, nicolas.dichtel@6wind.com,
davem@davemloft.net, linux-kernel@vger.kernel.org,
lukas.bulwahn@gmail.com
Subject: [RESEND] drbd: avoid clang warning about pointless switch statement
Date: Mon, 17 Sep 2018 14:54:34 +0200 [thread overview]
Message-ID: <4ffc2255-2ae2-60d4-703e-151979efe7ab@gmx.de> (raw)
The drbd code causes warnings that we cannot easily disable when
building with clang:
In file included from drivers/block/drbd/drbd_debugfs.c:10:
In file included from drivers/block/drbd/drbd_int.h:48:
In file included from include/linux/drbd_genl_api.h:53:
In file included from include/linux/genl_magic_struct.h:237:
include/linux/drbd_genl.h:300:1: warning: no case matching constant
switch condition '0'
There is nothing wrong with the code, and adding 'default:' labels
in the right place is enough to let clang shut up about the warning.
Fixes: ec2c35ac1ea2 ("drbd: prepare the transition from connector to
genetlink")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
--
was sent on Feb. 1, 2017, 4:55 p.m. UTC by Arnd Bergmann
was acked but not merged
resend
---
include/linux/genl_magic_struct.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/genl_magic_struct.h
b/include/linux/genl_magic_struct.h
index 6270a56e5edc..c6fbafb834f1 100644
--- a/include/linux/genl_magic_struct.h
+++ b/include/linux/genl_magic_struct.h
@@ -190,6 +190,7 @@ static inline void ct_assert_unique_operations(void)
{
switch (0) {
#include GENL_MAGIC_INCLUDE_FILE
+ default:
;
}
}
@@ -208,6 +209,7 @@ static inline void
ct_assert_unique_top_level_attributes(void)
{
switch (0) {
#include GENL_MAGIC_INCLUDE_FILE
+ default:
;
}
}
@@ -218,6 +220,7 @@ static inline void ct_assert_unique_ ## s_name ##
_attributes(void) \
{ \
switch (0) { \
s_fields \
+ default: \
; \
} \
}
reply other threads:[~2018-09-17 12:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ffc2255-2ae2-60d4-703e-151979efe7ab@gmx.de \
--to=phil_k97@gmx.de \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=drbd-dev@lists.linbit.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=nicolas.dichtel@6wind.com \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®